Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded icon path in Linux launcher file #3618

Closed
palob opened this issue May 13, 2016 · 2 comments
Closed

Hardcoded icon path in Linux launcher file #3618

palob opened this issue May 13, 2016 · 2 comments
Milestone

Comments

@palob
Copy link

palob commented May 13, 2016

Environment (OS name and version): Any GNU/Linux distribution

Hi,
currently the icon path in the created .desktop launcher file is hardcoded to:
Icon=/usr/share/redis-desktop-manager/bin/rdm.png

This prevents icon theming without editing the launcher file.

I'd like to ask you to change the icon location as well as the icon path line in the launcher according to the freedesktop.org standards.

Please find more info here:
http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
https://github.com/Foggalong/hardcode-fixer/wiki/What,-Why-&-How

According to the above resources standard icon locations are:

/usr/share/icons/hicolor/[size]/apps/[icon name]
~/.local/share/icons/hicolor/[size]/apps/[icon name]
/usr/share/pixmaps/[icon name]

The corresponding standard icon line in the .desktop launcher is:
Icon=[icon name] (without full path, without file extension)

For an icon rdm.svg or rdm.png stored in a standard location it would read:
Icon=rdm

Cf. this example .desktop launcher.

Could you please install the icon to one of those locations and adjust the icon path in the .desktop file accordingly?

@uglide uglide modified the milestones: 0.9.0, 1.0.0 Jun 9, 2016
@katuknow katuknow removed this from the 1.0.0 milestone Sep 15, 2017
@uglide uglide added this to the 1.0.0 milestone Jan 26, 2018
@uglide uglide modified the milestones: 1.0.0, 0.9.4 Jun 13, 2018
@uglide
Copy link
Collaborator

uglide commented Jun 13, 2018

Fixed in 0.9.4

@uglide uglide closed this as completed Jun 13, 2018
@palob
Copy link
Author

palob commented Jun 13, 2018

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants