Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON.stringify: Return type should include undefined #6

Closed
kku39 opened this issue Nov 15, 2021 · 1 comment
Closed

JSON.stringify: Return type should include undefined #6

kku39 opened this issue Nov 15, 2021 · 1 comment
Labels
bug Something isn't working
Milestone
2.0.1

Comments

@kku39
Copy link

kku39 commented Nov 15, 2021

Thanks a lot for fixing #5.

By the way, after the fix of #5, JSON.stringify can receive undefined, symbol, and more.

When JSON.stringify receives them, it returns undefined. So its return type should be string | undefined, isn't it?
@uhyo uhyo added the bug Something isn't working label Nov 15, 2021
@uhyo uhyo added this to the 2.0.1 milestone Nov 18, 2021
@uhyo uhyo closed this as completed in 9e7bf4d Apr 29, 2022
@uhyo
Copy link
Owner

uhyo commented Apr 29, 2022

Thank you, fixed in 2.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
2.0.1
Development

No branches or pull requests
2 participants
@uhyo @kku39