Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inactive label remains when tab becomes active #115

Closed
emadd opened this issue Jul 11, 2017 · 3 comments
Closed

Inactive label remains when tab becomes active #115

emadd opened this issue Jul 11, 2017 · 3 comments
Labels

Comments

@emadd
Copy link

emadd commented Jul 11, 2017

simulator screen shot jul 11 2017 8 14 35 am

@msaps
Copy link
Member

msaps commented Jul 11, 2017

Hi,

Is your indicator color translucent by any chance (appearance.indicator.color)? Currently the underlying (non-highlighted) buttons are not masked by the indicator which is why it might be visible. So this is something that definitely needs looking at!

Also, looks as though you are using a custom font? From what I can see I don't think this is being correctly applied to the selected buttons.

Would you be able to provide your TabmanBar.Appearance configuration? Just so I can accurately reproduce and see what's going on ? ☺️

Thanks!

@emadd
Copy link
Author

emadd commented Jul 11, 2017

No alpha at play as far as I can tell. The font appears to enlarge slightly when selected, but the unselected state label is obviously still there.

let darkTabbedColor: UIColor = UIColor.init(hexString: "#1c1f22")
let lightTabbedColor: UIColor = UIColor.init(hexString: "#303336")

self.bar.appearance = TabmanBar.Appearance({ (appearance) in
            appearance.style.showEdgeFade = true
            appearance.state.color = UIColor.white.darken(byPercentage: 0.3)
            appearance.state.selectedColor = .white
            appearance.style.background = TabmanBarBackgroundView.BackgroundStyle.solid(color: lightTabbedColor)
            appearance.indicator.color = darkTabbedColor
            appearance.layout.itemVerticalPadding = 0
            appearance.indicator.bounces = true
            appearance.indicator.lineWeight = .normal
            appearance.layout.height = TabmanBar.Height.explicit(value: 37.0)
            appearance.text.font = UIFont(name: "OpenSans", size: 15)
            appearance.layout.edgeInset = 0
            appearance.layout.interItemSpacing = 1
            
})

@msaps
Copy link
Member

msaps commented Jul 13, 2017

This is now resolved as of 0.7.3. 🎉

@msaps msaps closed this as completed Jul 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants