Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: TASK_PATCH_EXPORT_WIN_REVIEW not registered #7147

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

peterhudec
Copy link
Contributor

Description of change

Fixes a bug when an export win review couldn't be submitted because the TASK_PATCH_EXPORT_WIN_REVIEW task was registered to undefined because it was imported from a wrong module.

Test instructions

  1. Go to /exportwins/review/<token>
  2. Fill out the whole form
  3. Finally hit the Confirm and send button
  4. There should be no error related to TASK_PATCH_EXPORT_WIN_REVIEW not being registered in the console and you should be redirected to the success page saying "Export win reviewed"

@peterhudec peterhudec requested a review from a team as a code owner September 12, 2024 11:43
Copy link

cypress bot commented Sep 12, 2024

data-hub-frontend    Run #55793

Run Properties:  status check passed Passed #55793  •  git commit 9d4172b0bc: Fixed wrong import of patchExportWinReview
Project data-hub-frontend
Branch Review fix/patch-export-wins-review-task-not-registered
Run status status check passed Passed #55793
Run duration 01m 37s
Commit git commit 9d4172b0bc: Fixed wrong import of patchExportWinReview
Committer Peter Hudec
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 15
View all changes introduced in this branch ↗︎

@peterhudec peterhudec merged commit 1cec732 into main Sep 12, 2024
14 checks passed
@peterhudec peterhudec deleted the fix/patch-export-wins-review-task-not-registered branch September 12, 2024 12:54
@peterhudec peterhudec mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants