-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two-step adsorption relaxation #90
Comments
I agree. More generally, I was thinking it would be good to use separate Fireworks within a Workflow for each step of the process (copy |
I think this is a good idea for small adsorbates, but I'm not sure how this would interact with something more complicated like a C2 adsorbate with more degrees of freedom. |
Is the issue that many ionic steps are spent getting an adsorbate placed too far from the surface to approach the surface when all adsorbate atoms can move in all degrees of freedom? Perhaps larger adsorbates could be handled by making a custom ASE constraint that converts the entire adsorbate into a big rigid rotor. After it approaches and aligns with the surface, the constraints could be relaxed to Hookean constrains on the bonds, or removed altogether. |
Regarding restarts: I think that's something else entirely that would absolutely be worth looking into, but might be too much to lump into this issue. If we think that restarts would be valuable, then I'd recommend making that change alone and then revisiting this afterwards. Regarding complicated adsorbates: I think Zack was questioning the helpfulness of this procedure for larger adsorbates. We could do a pre-relaxation in the Z-direction, but if we then release the complicated adsorbates and they end up reconfiguring anyway, we could just be adding overhead without much value. But I think this specific issue is really only worth worrying about if people are actually using GASpy on these complicated adsorbates, which we are not doing right now. Regarding custom constraints: It's worth noting that the last time we tried, VASP could not handle custom constraints. We had to fall back to letting ASE do the relaxations while using VASP as a single-point calculator. Not a huge deal, just something to remember and address when making the FireWorks. |
@ktran9891 Totally with you; restart capability was just an extra thought I had. I agree that this isn't high priority, and we have no plans for running large adsorbates right now. Yes, I was thinking about handling all constraints for the initial relaxation through ASE. |
Apparently, it may be faster to:
If we were to do this, I'd recommend changing
gaspy.fireworks_helper_scripts.make_firework
and adding the 2-step procedure within a rocket.The text was updated successfully, but these errors were encountered: