Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

Joints are all reported as the same radius #2

Closed
rblenkinsopp opened this issue Jul 9, 2020 · 8 comments
Closed

Joints are all reported as the same radius #2

rblenkinsopp opened this issue Jul 9, 2020 · 8 comments
Labels
bug Something isn't working

Comments

@rblenkinsopp
Copy link
Member

rblenkinsopp commented Jul 9, 2020

The same radius is reported for all the joints in the hand. This can lead to odd-looking visualisations of the hand if these radii are used to size finger proxy objects.

This is currently a limitation of the underlying LeapC library which returns the same value for all joints. Possible solutions to this include:

  • Enhancing LeapC with finger width support
  • Use sensible defaults of the joint widths based on average hand measurements (possibly looked up based on finger length)
@rblenkinsopp rblenkinsopp added the bug Something isn't working label Jul 9, 2020
@bjornbytes
Copy link

Doesn't LeapC expose joint radius as LEAP_BONE.width?

@rblenkinsopp
Copy link
Member Author

Doesn't LeapC expose joint radius as LEAP_BONE.width?

I've made the description of the issue clearer. You are correct that LEAP_BONE.width exists, but it returns the same width for all joints, rather the correct value for each joint.

@bjornbytes
Copy link

Ah, oh well. Thanks for the clarification!

@maluoi
Copy link

maluoi commented Apr 17, 2021

For what it's worth here, I'd love to see some reasonable default joint sizes! I used to provide my own defaults before I switched to the radius provided by OpenXR, and now I don't have a nice way to decide if I should switch back to my own. Since I use this info for generating finger tubes, this can result in some really noodle-y looking fingers :)

@paulmelis
Copy link

paulmelis commented Mar 26, 2022

Are there any improvements for more realistic finger joint radii? I've been using StereoKit on a Varjo XR-3 and there the fingers are just way too big, making hand tracking almost unusable for certain types of interaction (as you loose precision and visual comprehension of where the fingers are). SK directly uses the joint radii provided by OpenXR.

@rblenkinsopp
Copy link
Member Author

If you are using OpenXR with a Varjo XR-3, I presume you don't have this API layer installed? The Varjo OpenXR runtime includes built-in support for the XR_EXT_hand_tracking extension as such doesn't require this layer to be installed for functional hand-tracking.

Currently, the finger-joint radius is a limitation of the underlying tracking system. I'll pass your feedback onto the team responsible, but we are also planning to look at providing more sensible defaults through this layer in the future.

@paulmelis
Copy link

If you are using OpenXR with a Varjo XR-3, I presume you don't have this API layer installed? The Varjo OpenXR runtime includes built-in support for the XR_EXT_hand_tracking extension as such doesn't require this layer to be installed for functional hand-tracking.

@rblenkinsopp I'm mere merely following up the original remarks from StereoKit's developer @maluoi on the hand tracking thickness. I guess StereoKit doesn't directly use this API layer. So would it be better to report this as an OpenXR issue with Varjo directly?

Currently, the finger-joint radius is a limitation of the underlying tracking system. I'll pass your feedback onto the team responsible, but we are also planning to look at providing more sensible defaults through this layer in the future.

Any progress would be great. Currently, this is what the finger radius looks like in StereoKit:

afbeelding

@rblenkinsopp
Copy link
Member Author

Closing this issue as this GitHub is being archived now the API layer is included as part of the standard Ultraleap Tracking Download. We are working on this on our layer, but if you are only working on top of Varjo, you should report it to them as well so it works with their implementation.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants