Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytorch hub and detect.py gives different results #7721

Closed
1 task done
kzyadaking opened this issue May 7, 2022 · 5 comments
Closed
1 task done

pytorch hub and detect.py gives different results #7721

kzyadaking opened this issue May 7, 2022 · 5 comments
Labels
question Further information is requested Stale Stale and schedule for closing soon

Comments

@kzyadaking
Copy link

Search before asking

Question

im using win32 instead of pill or mss for screengrab because this way its way faster than those two.
but the problem is sometimes it doesnt detect well compared to using detect.py. i have no idea where to look at.
does anyone have an idea?

import torch
import numpy as np
import win32gui
import win32ui
import win32con



w = 800 # set this
h = 600 # set this
bmpfilenamename = "color.bmp" #set this
windowname = 'put windowname'


def screenshot():
    hwnd = win32gui.FindWindow(None, windowname)
    wDC = win32gui.GetWindowDC(hwnd)
    dcObj=win32ui.CreateDCFromHandle(wDC)
    cDC=dcObj.CreateCompatibleDC()
    dataBitMap = win32ui.CreateBitmap()
    dataBitMap.CreateCompatibleBitmap(dcObj, w, h)
    cDC.SelectObject(dataBitMap)
    cDC.BitBlt((0,0),(w, h) , dcObj, (0,0), win32con.SRCCOPY)

#save the screenshot
#dataBitMap.SaveBitmapFile(cDC, bmpfilenamename)

signedIntsArray = dataBitMap.GetBitmapBits(True)
img = np.frombuffer(signedIntsArray, dtype='uint8')
img.shape = (h,w,4)

# Free Resources
dcObj.DeleteDC()
cDC.DeleteDC()
win32gui.ReleaseDC(hwnd, wDC)
win32gui.DeleteObject(dataBitMap.GetHandle())

#img = img[..., ::-1]
#img = np.ascontiguousarray(img)

return img

#load
model = torch.hub.load('./', 'custom', path='yolov5s.pt', source='local')


#inference
test = screenshot()
results = model(test)
boxes = results.pandas().xyxy[0]
print (boxes)

Additional

No response

@kzyadaking kzyadaking added the question Further information is requested label May 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented May 7, 2022

👋 Hello @kzyadaking, thank you for your interest in YOLOv5 🚀! Please visit our ⭐️ Tutorials to get started, where you can find quickstart guides for simple tasks like Custom Data Training all the way to advanced concepts like Hyperparameter Evolution.

If this is a 🐛 Bug Report, please provide screenshots and minimum viable code to reproduce your issue, otherwise we can not help you.

If this is a custom training ❓ Question, please provide as much information as possible, including dataset images, training logs, screenshots, and a public link to online W&B logging if available.

For business inquiries or professional support requests please visit https://ultralytics.com or email support@ultralytics.com.

Requirements

Python>=3.7.0 with all requirements.txt installed including PyTorch>=1.7. To get started:

git clone https://github.com/ultralytics/yolov5  # clone
cd yolov5
pip install -r requirements.txt  # install

Environments

YOLOv5 may be run in any of the following up-to-date verified environments (with all dependencies including CUDA/CUDNN, Python and PyTorch preinstalled):

Status

CI CPU testing

If this badge is green, all YOLOv5 GitHub Actions Continuous Integration (CI) tests are currently passing. CI tests verify correct operation of YOLOv5 training (train.py), validation (val.py), inference (detect.py) and export (export.py) on macOS, Windows, and Ubuntu every 24 hours and on every commit.

@glenn-jocher
Copy link
Member

glenn-jocher commented May 7, 2022

@kzyadaking we don't assist in debugging custom code, but obviously I'd recommend you compare whatever the image your code is producing with the official screenshot inference example in our PyTorch Hub tutorial:

YOLOv5 Tutorials

Good luck 🍀 and let us know if you have any other questions!

@kzyadaking
Copy link
Author

@glenn-jocher thanx for the reply. i found a solution! for those who might be interested,

#change this 
results = model(test) 

#to this
results = model(cv.cvtColor(test, cv.COLOR_BGR2RGB))

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2022

👋 Hello, this issue has been automatically marked as stale because it has not had recent activity. Please note it will be closed if no further activity occurs.

Access additional YOLOv5 🚀 resources:

Access additional Ultralytics ⚡ resources:

Feel free to inform us of any other issues you discover or feature requests that come to mind in the future. Pull Requests (PRs) are also always welcomed!

Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐!

@github-actions github-actions bot added the Stale Stale and schedule for closing soon label Jun 7, 2022
@glenn-jocher
Copy link
Member

Glad to hear you found a solution, @kzyadaking! Thanks for sharing it with the community. Your contribution is valuable 💪. Let us know if you need further assistance or have any more tips to share!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested Stale Stale and schedule for closing soon
Projects
None yet
Development

No branches or pull requests

2 participants