Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change api format to be consistent with other rpc endpoints #2

Open
ckoopmann opened this issue Sep 27, 2023 · 1 comment
Open

Change api format to be consistent with other rpc endpoints #2

ckoopmann opened this issue Sep 27, 2023 · 1 comment

Comments

@ckoopmann
Copy link
Collaborator

For historical reasons in the current version we use an api format different from the standard rpc encoding:

  1. snake_case field names (instead of camelCase)
  2. decimal encoded numbers (instead of hex encoding)

If we avoid these differences we could drop all of the code in src/rpc/types.rs

@alextes
Copy link
Member

alextes commented Sep 27, 2023

Let's use camelCase and hex then. If the relay breaks with client specs I'd rather it do the work to make it readable to clients like Reth.

Question: does Reth support SSZ encoding for the data we need to pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants