Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking change]: ASCII encoding of media file names from V16 #23

Open
2 tasks
kjac opened this issue Nov 28, 2024 · 0 comments
Open
2 tasks

[Breaking change]: ASCII encoding of media file names from V16 #23

kjac opened this issue Nov 28, 2024 · 0 comments

Comments

@kjac
Copy link

kjac commented Nov 28, 2024

Description

This PR introduces the option to ASCII encode media file names in V13.6 and V15.1, similarly to how URL segments are ASCII encoded by default.

To maintain backwards functional compatiblity, the option is introduced as default disabled. But ASCII encoding is a desired default behavior, so from V16 it will be default enabled.

Notice that:

  1. Existing media file names will not be affected - they will remain as-is after upgrading to V16.
  2. The current behavior of "default char replacements" (via the configuration option RequestHandler:EnableDefaultCharReplacements) will not be impacted by this change.

Version

Umbraco 16

Previous behavior

Media file names was not ASCII encoded by default.

New behavior

Media file names will be ASCII encoded by default.

Type of breaking change

  • Binary incompatible: Existing binaries may encounter a breaking change in behavior, such as failure to load/execute or different run-time behavior.
  • Source incompatible: Source code may encounter a breaking change in behavior when targeting the new runtime/component/SDK, such as compile errors or different run-time behavior.

Reason for change

ASCII encoding media file names by default will increase consistency between the generated document and media URLs.

Recommended action

To avoid ASCII encoded media file names, use the configuration option RequestHandler:ConvertFileNamesToAscii to disable this feature.

Affected APIs

None.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant