LogIncompletedScopes was removed but still documented

[matteus-hemstrom-nltg]

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.3.1

Bug summary

I'm not sure if this is a documentation issue or bug. I think that LogIncompletedScopes no longer works. It is documented here: https://docs.umbraco.com/umbraco-cms/reference/configuration/debugsettings

Specifics

I believe the logging code that used this setting was removed in this PR as part of moving logic into CoreScope.

This used to be part of ChildCompleted in Scope.cs:

if (_coreDebugSettings.LogIncompletedScopes)
{
    _logger.LogWarning("Uncompleted Child Scope at\r\n {StackTrace}", Environment.StackTrace);
}

Steps to reproduce

Not sure, but setting LogIncompletedScopes does nothing.

Expected result / actual result

LogIncompletedScopes should log warnings on uncompleted scopes. (Or update documentation.)

[github-actions]

Hi there @matteus-hemstrom-nltg!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

• We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
• If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
• We'll replicate the issue to ensure that the problem is as described.
• We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[Migaroez]

Hey @matteus-hemstrom-nltg, good catch and thank you for reporting this oversight. I will have a chat with the team if want to move this functionality in the corescope or remove the docs.

[Migaroez]

Hey @matteus-hemstrom-nltg, my apologies for the late reply. We have discussed this and think the best course of action is to reintroduce the logging back into cores cope in the same method.

[github-actions]

Hi @matteus-hemstrom-nltg,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)