Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple package references to Serilog.AspNetCore in v12/dev branch #15280

Closed
matteus-hemstrom-nltg opened this issue Nov 22, 2023 · 3 comments
Closed

Comments

@matteus-hemstrom-nltg
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

12.3.3

Bug summary

There are two <PackageReference> elements for Serilog.AspNetCore in the dev branch for v12. One references 7.0.0 and the other 5.0.0. I think this is due to a mistake in a merge. See:
https://github.com/umbraco/Umbraco-CMS/blob/v12/dev/src/Umbraco.Web.BackOffice/Umbraco.Web.BackOffice.csproj#L15-L16

Specifics

No response

Steps to reproduce

See https://github.com/umbraco/Umbraco-CMS/blob/v12/dev/src/Umbraco.Web.BackOffice/Umbraco.Web.BackOffice.csproj#L15-L16

Expected result / actual result

No response

Copy link

Hi there @matteus-hemstrom-nltg!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@kjac
Copy link
Contributor

kjac commented Nov 27, 2023

Hi @matteus-hemstrom-nltg,

Thank you for reaching out and for pointing this out ❤️ and not least for digging into the root cause 💪

We're currently in the process of redoing our package references, so the package versions will be managed in one central file for all projects. We do expect this to be done soon, thus eliminating these silly errors in the future.

The initial PR is here: #15293 - it targets V10, but once it's in we'll merge it to the later versions too (taking into account the newer package versions as we progress through the CMS versions).

I'm cross linking your issue to the PR. Hopefully it'll be tracked and auto-closed by GitHub once the PR is merged. 🙈

@kjac
Copy link
Contributor

kjac commented Nov 27, 2023

Fixed in #15293 (that is, when #15293 is merged to V12 😄 )

@kjac kjac closed this as completed Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants