Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v14-rc2 - add custom view to a block in the settings of a Block Grid datatype #16134

Closed
mjpraxis opened this issue Apr 23, 2024 · 4 comments · Fixed by umbraco/Umbraco.CMS.Backoffice#2065

Comments

@mjpraxis
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v14-rc2

Bug summary

When adding a custom view to a block in a block grid data type it is not visible that there is a custom view selected.

Specifics

Chrome Version 124.0.6367.61

Steps to reproduce

Create some very simple document-/element types and datatype

ElementType: with one property eg. "bodytext" (Textarea)
DataType: "Block Grid Property Editor UI" with the above Element Type added to the list of Blocks
Add a .html to the "Custom view" list
image
And finally save the datatype

Expected result / actual result

Expected result:
To see the selected .html file in the list of Custome view.

Actual result:
The Custom view list is empty

Observations:
The PUT request made at the data type save. Has the selected file in the payload json.
image

Copy link

Hi there @mjpraxis!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@elit0451 elit0451 changed the title v14-rc2 - add custom view to a block in the settings of a Block Grid datatype v14-rc1 - add custom view to a block in the settings of a Block Grid datatype Apr 25, 2024
@Zeegaan Zeegaan changed the title v14-rc1 - add custom view to a block in the settings of a Block Grid datatype v14-rc2 - add custom view to a block in the settings of a Block Grid datatype Apr 29, 2024
@Zeegaan
Copy link
Member

Zeegaan commented Apr 29, 2024

I can definitely reproduce this, thanks for reporting 🐛

@nielslyngsoe
Copy link
Member

This will be, sort of, fixed as part of this PR:
umbraco/Umbraco.CMS.Backoffice#2065

As v.14 comes with a Extension Registry, this has allowed us to finally move Custom Views into code, making them a Backoffice extensions them selfs.

Therefor it will no longer possible to pick a file via UI, this is done in the same way s any other UI extension.

@MichaelNielsenDK
Copy link

I don't know if it's just me, but I feel like there is some confusion on how this is handled now for Block Lists.

In v14.2 Block Grid has a "Custom View" section under the "Advanced" tab
image

But Block List has no "Advanced" tab or "Custom Views" section
image

Documentation seems to be the old AngularJS way
https://docs.umbraco.com/umbraco-cms/fundamentals/backoffice/property-editors/built-in-umbraco-property-editors/block-editor/build-custom-view-for-blocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants