Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property description styling is broken #16499

Closed
prjseal opened this issue May 29, 2024 · 4 comments
Closed

Property description styling is broken #16499

prjseal opened this issue May 29, 2024 · 4 comments

Comments

@prjseal
Copy link
Contributor

prjseal commented May 29, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

v14 rc5

Bug summary

In Umbraco we are able to add some simple styling to the property description.

As per the documentation and this YouTube video

If we add the following in the description of a property:

This is **bold**
This is *italic*
[This is an absolute link](https://google.com)
[This is a relative link](/umbraco#/media)
--
![Image alt text](https://media.giphy.com/media/bezxCUK2D2TuBCJ7r5/giphy.gif)

It should come out looking like this, with the gif being revealed by a read more link and a close link.

image

Instead it comes out looking like this where the font weight is incorrect, the read more doesn't work and the image overflows the width.

image

Specifics

See above

Steps to reproduce

See above

Expected result / actual result

I expect the styling to be similar and the read more functionality to work

Copy link

Hi there @prjseal!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

Hey @prjseal, thanks for testing. We wondered if we should set a max-width on all images within property descriptions, but it seemed dangerous to do so. It seems you would expect exactly that to happen here. I think we need to look more into it and see, as putting markdown into property descriptions is allowing for all sorts of things to be inserted. The old backoffice only allowed a subset of Markdown in this area, and apparently had some custom functionality such as "Read more".

@iOvergaard iOvergaard added state/needs-investigation This requires input from HQ or community to proceed area/frontend affected/v14 labels May 30, 2024
@leekelleher
Copy link
Member

To note the --, is Markdown syntax for a heading, (albeit alternative syntax to #), so technically it shouldn't have been used as the syntax to render a "read more" toggle in previous Umbraco versions. We'll look for an alternative syntax for a collapsible (read more) description, and update the docs accordingly.

In the meantime, it's now possible to have sanitized HTML inside the description, so markup like <details><summary> could be used.

@leekelleher
Copy link
Member

I've added a fix for the image width, umbraco/Umbraco.CMS.Backoffice#1961.

We'll be investigating whether we'll still support the "read more" feature, or if we encourage the use of <details> as an alternative.

@iOvergaard iOvergaard added state/reproduced release/14.1.0 and removed state/needs-investigation This requires input from HQ or community to proceed labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants