Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbraco 14 - ModelsBuilder generates integer label as a string in the model #16613

Open
jovanzlatanovic opened this issue Jun 18, 2024 · 3 comments

Comments

@jovanzlatanovic
Copy link

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.0.0

Bug summary

I have a composition which contains a label with a value type set as integer. Upon generating models after upgrade, the .generated.cs file changes the value type to string.

Specifics

Upon generating models with ModelsBuilder the models which inherit a composition that contains a Label (integer) field, the generated values are no longer of type integer but of string.

image

image

Steps to reproduce

  1. Create a composition containing a Label (integer) field, and create a document type which inherits the composition.
  2. Generate models using ModelsBuilder (SourceCodeManual)

Expected result / actual result

Expected:
Expecting that the generated model contains an integer property type.

Actual:
Generated model property is a string instead.

Copy link

Hi there @jovanzlatanovic!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@NguyenThuyLan
Copy link
Contributor

Hi @jovanzlatanovic , Thank for reporting this.
I can reproduce it on v14.1.1 and I will let the team know 👍

@mdeslauriers-sigmund
Copy link
Contributor

mdeslauriers-sigmund commented Sep 24, 2024

I also can reproduce it on v14.2.0 it also seems to affects datetime and bigint

Update 2024-10-23 : still occurs in v14.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants