-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embeds in RTE are not included #16806
Comments
Hi there @jemayn! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hey @jemayn 👋 It is nice to hear from you! Thanks for reaching out. 🙂 I am able to reproduce the issue, and it seems like adding text before it makes it stay: EmbedVideoRTE.movWe would love some help fixing this 🙌 so I will mark it as up for grabs. Meanwhile, there is the workaround. |
Hi @jemayn, We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know. For more information about issues and states, have a look at this blog post. Thanks muchly, from your friendly Umbraco GitHub bot :-) |
Hi @jemayn, We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know. For more information about issues and states, have a look at this blog post. Thanks muchly, from your friendly Umbraco GitHub bot :-) |
This should have been fixed in V14+. I am not sure if there is an easy fix in older Umbraco versions, but if anyone is willing to confirm that it works or is still a problem, feel free to do so! |
Hey @iOvergaard I can no longer reproduce my original issue on 13.5.2. Seems like #17008 has fixed it 🙂 Thanks to the team! I am closing this issue. |
Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)
13.4.1
Bug summary
When I add an embed in an RTE it removes it on save.
I've found this issue which seems related but mentions it only being an issue specifically in an RTE in a grid: #11755
It sometimes allows me to add the embed, then afterwards if I try to edit the width/height of the included embed it doesn't save that change either.
Specifics
Initially found the issue on 13.3.2, tested on latest 13.4.1 and could reproduce (see below)
Steps to reproduce
I've reproduced this on a fresh site:
Here is what happened:
embed.mp4
Expected result / actual result
Expect it to save the embed properly, and also update it when I try to change it.
This item has been added to our backlog AB#43610
The text was updated successfully, but these errors were encountered: