Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content picker search is broken #17343

Closed
StudioBravo opened this issue Oct 23, 2024 · 4 comments
Closed

Content picker search is broken #17343

StudioBravo opened this issue Oct 23, 2024 · 4 comments

Comments

@StudioBravo
Copy link

StudioBravo commented Oct 23, 2024

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

14.3.1

Bug summary

The content picker search functionality seems to be searching across all content across the site rather than the restricted content for the picker.

Specifics

No response

Steps to reproduce

  • Setup a document type that contains a field with a content picker
  • Restrict the content picker only to select certain document types and also specify a starting node
  • Create a page with the new document type and navigate to the content picker to add content
  • The content picker selection flyout shows all available content (it correctly displays the restricted set of content to chose from)

image

  • Start typing on the search box and it seems to find all the content cross the site that matches the text.

image

Expected result / actual result

The search functionality should be looking through the restricted documents rather than across the whole site.


This item has been added to our backlog AB#45280

Copy link

Hi there @StudioBravo!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@Zeegaan Zeegaan self-assigned this Oct 23, 2024
@Zeegaan
Copy link
Member

Zeegaan commented Oct 24, 2024

I can reproduce this, looks like when we are calling the search endpoint, we are no longer accounting for the context of the content picker 😁

@Zeegaan Zeegaan removed their assignment Oct 24, 2024
@nikolajlauridsen
Copy link
Contributor

I just looked at this, and this turns out to be a frontend issue.

On 13 there was a "start from" query parameter on the tree search, which would limit the search to a specific start node. This query parameter is still there for /item/document/search just called parentId now which the frontend should use but doesn't.

Similarly, on V13 the frontend did a lookup on the datatype and used the filter property to filter out the document types that aren't allowed according to the configuration, this doesn't happen either 😄

@madsrasmussen
Copy link
Contributor

This is now fixed and will be available in 15.1

@madsrasmussen madsrasmussen added release/15.1.0 and removed state/sprint-candidate We're trying to get this in a sprint at HQ in the next few weeks state/reproduced affected/v14 affected/v15 labels Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants