Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown (in Property Descriptions) are not properly rendering if repeated. See example. #17646

Closed
markadrake opened this issue Nov 26, 2024 · 4 comments

Comments

@markadrake
Copy link
Contributor

Which Umbraco version are you using? (Please write the exact version, example: 10.1.0)

13.5.2

Bug summary

Repeated use of "markdown" in your property descriptions
can cause strange effects.

Specifics

No response

Steps to reproduce

  • Given any property editor,
  • Fill out the description with the text below.
  • Save your changes.
  • The bold text will instead span from the beginning of the first, to the end of the last.
Filter the list of suppliers by connecting a **type** of service record to one or more **categories**.

image

image

Expected result / actual result

I expect only the words type and categories to be rendered boldly.

This is the result:

image

image

Copy link

Hi there @markadrake!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@iOvergaard
Copy link
Contributor

Hello, thanks for reporting this. I am a bit unsure whether the markdown syntax was ever really supported in property descriptions in V13 and below. It seems the implementation is rather custom and not sanitized by any client-side library. "Real" Markdown is supported from V14 and up, so this particular issue is not present there at least. I can verify that the issue exists up to V13. I would like to mark this issue as up-for-grabs as we'd be happy to accept a pull request that fixes the issue.

Copy link

Hi @markadrake,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

@iOvergaard
Copy link
Contributor

Thanks to @danlister, this has been fixed in 13.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants