Update/replace legacy dotnet new umbraco-package template with RCL
#15258
Conversation
|
This will surely help @leekelleher with his efforts to create a modern package template for V14 as well 😎 |
|
@ronaldbarendse @iOvergaard To clarify what's happening here, does this mean that the Would this mean that for the v14 version of the template, we would only need the RCL version? |
Yes, that is correct. How do you find that change? Any downsides? |
@iOvergaard No downsides from me. Makes PR #14975 simpler. 👍 |
| "Framework": { | ||
| "longName": "Framework", | ||
| "shortName": "F", | ||
| "longName": "framework", | ||
| "shortName": "f", | ||
| "isHidden": true | ||
| }, | ||
| "UmbracoVersion": { | ||
| "longName": "version", | ||
| "shortName": "v" | ||
| "shortName": "" | ||
| }, |
There was a problem hiding this comment.
These changes have already been discussed in #13776 (comment) and we shouldn't keep pushing this change back (especially since we only allow a single framework version anyway)...
|
|
||
| <Import Project="..\PACKAGE_PROJECT_NAME_FROM_TEMPLATE\buildTransitive\PACKAGE_PROJECT_NAME_FROM_TEMPLATE.targets" Condition="'$(PackageProjectName)' != ''" /> | ||
| <ItemGroup Condition="'$(PackageProjectName)' != ''"> | ||
| <ProjectReference Include="..\PACKAGE_PROJECT_NAME_FROM_TEMPLATE\PACKAGE_PROJECT_NAME_FROM_TEMPLATE.csproj" /> | ||
| </ItemGroup> |
There was a problem hiding this comment.
RCLs can be added as a regular project reference, so we don't need the PackageProjectName template parameter anymore. Adding the reference can be easily done in the IDE or using dotnet add <PROJECT> reference <PROJECT_PATH>...
Co-authored-by: Elitsa <elm@umbraco.dk>
* Cache block item constructors for block based editors * Fix unit tests * Fixed Grid unit tests * Clear constructor caches when content types and data types change (to support InMemoryAuto models)
* Implement DeliveryApiCompositeIdHandler * Replace duplicate decomposing with Handler instead * Add obsolete messages * Make Id integer instead of string * Move from examine to core --------- Co-authored-by: Zeegaan <nge@umbraco.dk>
* Log meaningful job names and use template based log messages * Review changes
… UmbracoContextPublishedSnapshotAccessor
* add check for the presence of the ?logout=true parameter on the login screen to avoid autoredirect to external login * refactor controller to eliminate need for duplicate defaultResponse and externalLoginResponse (they are always the same) * refactor to reduce nesting
* Expose the Delivery API CLR type * Updated field naming and warnings Addresses PR feedback * Added default implementation to prevent breaking change (cherry picked from commit 7f43780)
… and `TryGetValue()`/`GetEntityTypes()` to `IFileTypeCollection`) (#15318)
|
This is now done in PR #17108 👌🏻 |
Prerequisites
Description
With Razor Class Library support added in .NET 6 and Umbraco having proper support for it since v11 (see PR #13141), we should remove the legacy package template that uses custom build targets and replace it with the RCL version (that was added as
umbraco-package-rclin v11.4, see PR #13776).This also
updates the(already fixed in #15268) aligns the target framework version parameter casing with .NET default templates.Microsoft.ICU.ICU4C.Runtimedependency to 72.1.0.3 (this was already done in the Umbraco.Web.UI project, just not in the template) andTesting can be done by getting the
Umbraco.Templates.*.nupkgasset from the build, installing that and creating a new Umbraco project and package.