Fix build errors due to merge of PR #16991 #17176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts.csproj and Umbraco.Core.csproj LocalFileSystemTemporaryFileRepository: Don't pass null to a method that doesn't accept nullable argument - https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2264 Fix remaining warning marked as error
nul800sebastiaan
deleted the
chore/fix-warn-as-erros-problems-preventing-build
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Makes the project build and fixes newly introduced errors that are no longer treated as warnings any more.
Note:
LocalFileSystemTemporaryFileRepositoryhad aArgumentNullException.ThrowIfNull(nameof(model));at the start which is treated as error now, so it's been removed.Note2:
IUmbracoContexthad a commented outForcedPreviewmethod in it, the comments above it were treated as an error as there were no methods. As per usual, I completely removed commented out code (that's what Git is for 😅)