Fix greedy Install url detection #17241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Fixes #17017
Description
The logic that determines whether a request path is part of the installer will no longer greedily return true when the first segment of the url starts with the installer path (install), ie: installation
Testing
As described in the original issue, setup a standard site with everything under 1 "site" node, protect one of the pages directly under the site node with a standard member setup and make sure the name of the page's name starts with
install.Unit tests have been added to cover the buggy case and some other possible issues.
Considerations
This bug is most likely also present in all other active majors.