Update to Examine 3.4.0

[Shazwazza]

Prerequisites

• I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes

• Lucene.Net.Index.CorruptIndexException: invalid deletion count: 2 vs docCount=1  #16163
• Examine index recovery #17205

Description

Update to Examine 3.4.0, see release notes here https://github.com/Shazwazza/Examine/releases/tag/v3.4.0

[github-actions]

Hi there @Shazwazza, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

• It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
• The automated tests all pass (see "Checks" tab on this PR)
• The level of security for this contribution is the same or improved
• The level of performance for this contribution is the same or improved
• Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
• If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
• 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

[bjarnef]

@Shazwazza it seems you forgot to update Examine.Core reference as well.

[Shazwazza]

@bjarnef thanks, have updated

[bergmania]

Hi.. I have updated for v15 as part of a bigger nuget update PR (#17370).

One thing I noticed, is that we suddenly get exceptions when disposing, because something was already disposed. I'm afraid it will break peoples solutions, if we update on v13 and v14

[Shazwazza]

@bergmania do you have a stack trace or steps to replicate and then I can fix up.

[bergmania]

@Shazwazza, the test suites exploded, but I do not have the stacktrace at hand anymore.

I had to make this change:
https://github.com/umbraco/Umbraco-CMS/pull/17370/files#diff-77a94f4ca225bfcb32a30bef1ce75e54dbb570a693368bbf4ae64426ccd2205cR51-R58

[Shazwazza]

@bergmania From what I can see, the build pipelines worked for this, any chance you could find the stack trace? I very interested in getting to the bottom of this to see if this is an Examine change required or an Umbraco change.

Also, there will be another Examine release shortly with the updated Lucene.NET version (which has some breaking changes... but not breaking for Examine)

[Shazwazza]

@bergmania due to the new Lucene version, I would recommend getting that into version 15 especially considering the current Lucene.NET version has been flagged as a security risk (although the risk is almost nothing especially in Umbraco, but its listed as high severity :( )

[bergmania]

It's already merged to v15 as part of other updates. So v15 is not a risk.

I'll assume the PR passed because the latest contrib is merged.

By reverting https://github.com/umbraco/Umbraco-CMS/pull/17370/files#diff-77a94f4ca225bfcb32a30bef1ce75e54dbb570a693368bbf4ae64426ccd2205cR51-R58 you should see the error.

I'll see if I can find time tomorrow to find it

[umbrabot]

Hi there @Shazwazza!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!
This year's swag is a custom designed notebook and custom Umbraco Hacktoberfest sticker:

As an alternative choice, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 25th, 2024, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few weeks/months, so please bear with us and be patient 🙏

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.