Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix out of memory file upload of 2gb+ files introduced by #14657 SVG xss #17421

Open
wants to merge 2 commits into
base: v13/contrib
Choose a base branch
from
Open

Fix out of memory file upload of 2gb+ files introduced by #14657 SVG xss #17421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2745834
Fix out of memory of 2gb+ (max 4gb) error introduced by #14657 SVG xs…
TimBoonstra Nov 5, 2024
05d47b5
Merge branch 'v13/contrib' into v13/bugfix/out-of-memory-2gb-fix
TimBoonstra Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/Umbraco.Web.BackOffice/Controllers/MediaController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -788,8 +788,7 @@ public async Task<IActionResult> PostAddFile([FromForm] string path, [FromForm]
continue;
}

using var stream = new MemoryStream();
await formFile.CopyToAsync(stream);
await using var stream = formFile.OpenReadStream();
if (_fileStreamSecurityValidator != null && _fileStreamSecurityValidator.IsConsideredSafe(stream) == false)
{
tempFiles.Notifications.Add(new BackOfficeNotification(
Expand Down
Loading