Fixes to templates: Do not allow deletion of masters and ensure file names are pascal case #17539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ensure master templates cannot be deleted
bergmania
changed the title
nikolajlauridsen
approved these changes
Nov 15, 2024
…emplate-files-needs-to-have-capical-first-character
…have-capical-first-character
…needs-to-have-capical-first-character' into v15/bugfix/17458-Template-files-needs-to-have-capical-first-character
bergmania
deleted the
v15/bugfix/17458-Template-files-needs-to-have-capical-first-character
branch
bergmania
added a commit
that referenced
this pull request
Nov 19, 2024
andr317c
pushed a commit
that referenced
this pull request
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16443
Description
Template file names should be Pascal-case. We can do this my having a titlecase on the original alias.
Furthermore, ensure templates cannot be delete when it is a master template
Tests