V8/bugfix/3498 entity service updates #5658
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3498
Please read notes in the tasks and related links.
The gist is:
umbracoMediaVersion
table which contains the media pathSo this is all done and tons of code is cleaned up/removed. I'd wager that nobody was ever using the code that was removed. There would be no reason why anyone was using these services and passing in a true value for
loadBaseType
(orfull
).The
_mediaFileResolvers
stuff that was mentioned in one of those links still remains and that is fine, they are still used to resolve a media's path based on a full media item (i.e. when you click on a media folder in the media section... that said ... it would be much much faster and better performance to load in all media items and thumbnails when you click on a folder to use the EntityService, something to consider in the future since now it uses the MediaService which is loading in all property data!)Testing