You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Following an upgrade from a patched version of Vorto v1.6.0 (modified as per initial fix in PR #100) to Vorto 1.7.1, calling GetVortoValue with the recurse parameter set true doesn't recurse. The patch applied by PR #100 handles the null value issue but it doesn't include the option to recurse up the tree. The initially submitted version of the PR allows for recursion.
Sugest change to current patch:
if (prop == null)
{
// PR #100 - Prevent generation of NullReferenceException: allow return of defaultValue or traversal up the tree if prop is null
//return defaultValue;
return recursive && content.Parent != null? content.Parent.DoGetVortoValue<T>(propertyAlias, cultureName, recursive, defaultValue) : defaultValue;
}
The text was updated successfully, but these errors were encountered:
If someone could submit a PR, that would be appreciated. Currently away so can't address myself right now. Would make a great first time PR for someone.
The original version of PR #100 as submitted on 21 Nov 2017 and tidied up by Lee Kelleher on 27 Nov 2017 fixed the issue. The tweaked fix merged on 17 Feb 2018 actually removed the recursive option.
Following an upgrade from a patched version of Vorto v1.6.0 (modified as per initial fix in PR #100) to Vorto 1.7.1, calling GetVortoValue with the recurse parameter set true doesn't recurse. The patch applied by PR #100 handles the null value issue but it doesn't include the option to recurse up the tree. The initially submitted version of the PR allows for recursion.
Sugest change to current patch:
The text was updated successfully, but these errors were encountered: