-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
取消Footer的时候,下方padding为0,看着很难受 #1510
Comments
Hello @wizcheu. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please be sure to fill in the default template in the Pull Request, provide changelog/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution! 你好 @wizcheu,我们完全同意你的提议/反馈,欢迎直接在此仓库创建一个 Pull Request 来解决这个问题。请务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。 |
我来尝试解决一下~ |
方案一: 在 layout 中添加一个css选择器判断有没有 footer , has 有兼容性问题 can i use &:not(&:has(> .@{prefix}-footer)) {
margin-bottom: @s-content-padding;
}
方案二: 同 sidebar 逻辑一个加一个自定义属性 |
v2.1.15 已优化 |
https://github.com/umijs/dumi/blame/8e94e51886f025ef5c13412a91a4a35bcf7f6a00/src/client/theme-default/slots/Content/index.less#L150
The text was updated successfully, but these errors were encountered: