You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
users of github.com/umputun/reproxy/lib will have to update dependency path and version
I don't think these points are very critical: API of github.com/umputun/reproxy/lib is pretty stable, and the current version (v0.10.0) allows to make breaking changes
The text was updated successfully, but these errors were encountered:
this is a valid concern. Making submodule in go is smth awkward a little bit with an additional tag we will have to maintain for lib. However, breaking dependency to the github.com/umputun/reproxy is worth it in my opinion.
I'm not sure I understand the meaning of "will have to be vendored" item. Does it mean vendored by reproxy itself because it will be treated as a module and won't be resolvable "directly" anymore? Are you saying this won't work anymore unless vendored?
Does it mean vendored by reproxy itself because it will be treated as a module and won't be resolvable "directly" anymore? Are you saying this won't work anymore unless vendored?
At the moment, this is working as designed: go mod vendor doesn't know (or particularly care) about the overall repo structure — it just knows where the main module is and vendors in the dependencies of the main module wherever they are found.
Import of
github.com/umputun/reproxy/lib
addsgit.luolix.top/umputun/reproxy
togo.mod
. It results in a significant number of dependencies.At the same time,
github.com/umputun/reproxy/lib
requires only 3 dependencies:github.com/go-pkgz/lgr
github.com/go-pkgz/repeater
github.com/stretchr/testify
Making
github.com/umputun/reproxy/lib
a submodule can resolve this issue.However, this change will also require some additional work:
vX.Y.Z
forgit.luolix.top/umputun/reproxy
andlib/vX.Y.Z
forgit.luolix.top/umputun/reproxy/lib
github.com/umputun/reproxy/lib
will have to be vendored (see cmd/go: allow 'go mod vendor' to omit replaced modules golang/go#33789 and build: no longer use vendor directory hashicorp/nomad#10898)github.com/umputun/reproxy/lib
will have to update dependency path and versionI don't think these points are very critical: API of
github.com/umputun/reproxy/lib
is pretty stable, and the current version (v0.10.0
) allows to make breaking changesThe text was updated successfully, but these errors were encountered: