Targets excution

[polderudo]

I'm running into a problem with the evaluation of a target. Following script

ssh_key: ~/.ssh/deploy_rsa.private
local_shell: /bin/bash

targets:
  stage:
    hosts: [{host: "stage.server", user: "user", port: 666}]
  prod:
    hosts: [{host: "localhost"}]

tasks:
  - name: set global-vars
    options: {local: true}
    commands:
      - name: set global vars
        script: |
          BINARY_NAME=app         
          FRONTEND_LOCAL_DIR=frontend
          SRV_FILE_NAME=$(date '+%Y-%m-%d--%H.%M.%S').$BINARY_NAME
        register: [ BINARY_NAME,FRONTEND_LOCAL_DIR, SRV_FILE_NAME ]

  - name: set vars-stage
    targets: ["stage"]
    options: {local: true}
    commands:
      - name: set stage-vars
        script: |
          SUPERVISOR_NAME=em
          SERVER_DIR=/srv/app
          NODE_BUILD_TARGET=build
        register: [SERVER_DIR,NODE_BUILD_TARGET, SUPERVISOR_NAME]
        #options: {local: true}

  - name: set vars-prod
    targets: [ "prod" ]
    options: {local: true}
    commands:
      - name: set prod-vars
        script: |          
          NODE_BUILD_TARGET=build
        register: [NODE_BUILD_TARGET]

  - name: build vue
    options: {local: true}
    commands:
      - name: del dist folder
        script: rm -rf $FRONTEND_LOCAL_DIR/dist
      - name: build vue
        script: |
          #!/bin/bash
          . ~/.bashrc
          cd $FRONTEND_LOCAL_DIR
          nvm use
          npm run $NODE_BUILD_TARGET

  - name: build go
    options: {local: true}
    commands:
      - name: create binary
        script: make build-linux

  - name: manage server
    targets: ["stage"]
    options: {only_on: [stage]}
    commands:
      - name: copy to server
        copy: { "src": "$BINARY_NAME", "dst": "$SERVER_DIR/versions/$SRV_FILE_NAME" }

      - name: change sym-link to current version
        script: ln -fsn $SERVER_DIR/versions/$SRV_FILE_NAME $SERVER_DIR/$BINARY_NAME

      - name: migrate db
        script: |
          cd $SERVER_DIR 
          ./$BINARY_NAME migrate up

      - name: restart app
        script: |
          supervisorctl restart $SUPERVISOR_NAME  

So pretty basic one. 2 targets stage and prod. But somehow the last tast "manage server" is also called for prod target:

[localhost] completed task "build go", commands: 1 (1.82s)
failed, can't run task "manage server" for target "prod": 1 error(s) occurred:
   [0] failed to dial: dial tcp [::1]:22: connect: connection refused

Am i doing something wrong here? With targets: ["stage"] "manage server" should not be called at all right?

[umputun]

the description is a little bit confusing.

With targets: ["stage"] "manage server" should not be called at all right

Probably you meant "with targes prod here. Anyway, could you pls also show the command line(s) you used to run it?

[polderudo]

Yes, i mean with prod, sorry:
spot -t prod
is the command used

[polderudo]

Basicly the stage target copies stuff to the server, the prod build however should only build some stuff and then upload the binary to a artifactory (this is not in the script). Anyway the "manage server" should not be evaluated for target prod

[umputun]

I have not tried to replicate it, but from a quick view, your playbook seems to have a few issues:

• Misuse of targets in tasks. It is not a target selector (I think this is what you meant) but rather a very specific and rather exotic option to set dynamic targets. See https://spot.umputun.dev/#dynamic-targets for more details.
• Mixing "targets" and options: {local: true} in the same task. I'm not really sure what the goal was; this may be a result of the misuse mentioned above. Generally, targets are not for selecting tasks but rather for picking the set of destination hosts. By setting local: true, you eliminate the target completely, which is fine if the goal is to run some steps locally.
• The only_on you are using with the target name doesn't seem to match what the documentation specifies (the list of hosts). I don't recall if targets are even supported here, but it's unlikely because the goal of this option is to limit playbook execution to certain hosts within the target.

Generally, the root cause of this confusion is a mix-up between targets and tasks. For what you are trying to achieve, you just need to run different tasks. This can be either separate playbook files for production and staging or alternatively running the same playbook with only/skip flags.

[polderudo]

Yes you are right i am missusing the targets :) and of course i can use different playbooks for prod and stage or work with only/skip flags, but i though having everything in one spot-file and just distinguishing by the target would also work nice. It is working for setting the variables e.g.
Anyway the only_on is just there for testing. i tried also with the server-name but it did also not work.

But anyway would it be bad, if tasks / commands would not be executed, it the target does not match? I mean that would open a whole new way of creating the scripts?

[umputun]

You can have a single playbook file with different tasks. Each task may have multiple commands. Maybe organizing the playbook like this will achieve the goal you have in mind?

[polderudo]

or alternativly having a target selector like "only_for_task": []string that one could use to include/exclude tasks/commands for targets?

[umputun]

well, this is what tasks are for. if one want to execute just subset of tasks (i.e. a single task), the task name can be passed directly.

[umputun]

moving to discussion as I don't see a bug here