Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Clippy warnings #101

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix Clippy warnings #101

merged 1 commit into from
Jul 29, 2024

Conversation

Chris00
Copy link
Contributor

@Chris00 Chris00 commented Jul 27, 2024

Fix Clippy warnings — as agreed in #100 (comment)

@coveralls
Copy link

coveralls commented Jul 27, 2024

Pull Request Test Coverage Report for Build 10130426724

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 84.859%

Totals Coverage Status
Change from base Build 10124762615: -0.03%
Covered Lines: 2181
Relevant Lines: 2226

💛 - Coveralls

@unageek
Copy link
Owner

unageek commented Jul 28, 2024

Thank you for the PR!

Could you fix src/simd/aarch64.rs as well? I'll test it locally before merging.

@Chris00
Copy link
Contributor Author

Chris00 commented Jul 28, 2024

Maybe a test for aarch should be added to the CI?

@Chris00
Copy link
Contributor Author

Chris00 commented Jul 29, 2024

P.S. Once this is merged, I may also open another PR to add Unpin for (Dec)Interval.

@unageek
Copy link
Owner

unageek commented Jul 29, 2024

Maybe a test for aarch should be added to the CI?

Yes, I'll add the macos-latest runner, which runs on Apple M1.

P.S. Once this is merged, I may also open another PR to add Unpin for (Dec)Interval.

That sounds good! Please go ahead.

@unageek unageek merged commit d430581 into unageek:main Jul 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants