Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dynamic version fix #293

Merged
merged 2 commits into from
Aug 10, 2023
Merged

dynamic version fix #293

merged 2 commits into from
Aug 10, 2023

Conversation

aaarrti
Copy link
Collaborator

@aaarrti aaarrti commented Aug 10, 2023

Description

  • Fix for the installation problem toml missing #292, which was introduced in Fixes on v0.4.2 #291

  • import issue resolved

  • added step to python-package action, which check if the library is importable

To sum up, the __version__ must be defined in top-level __init__.py as a string literal,
then it will be dynamically fetched by flit during packaging stage.

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Merging #293 (f70dc29) into main (fa65c05) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
- Coverage   93.37%   93.37%   -0.01%     
==========================================
  Files          62       62              
  Lines        3473     3471       -2     
==========================================
- Hits         3243     3241       -2     
  Misses        230      230              
Files Changed Coverage Δ
quantus/__init__.py 100.00% <100.00%> (ø)

@aaarrti aaarrti marked this pull request as ready for review August 10, 2023 09:50
Copy link
Member

@annahedstroem annahedstroem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

@annahedstroem annahedstroem merged commit f971107 into main Aug 10, 2023
7 checks passed
@aaarrti aaarrti deleted the dynamic-version-installation-fix branch August 10, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants