Edit verse not being checked

[benjore]

User Story

As a checker who sees an error in a verse that is not being checked, I want to be able to edit a verse that is not being checked so that I don't go crazy or have to try to find a check in that verse before I can fix the error.

May be covered by #1999

Specs

• A reusable module needs to be created that contains the edit verse functionality.
  • A two step "stepper" is needed
  • Next is not active until a change has been made
  • Save is not active until a reason has been selected
  • Multiple reasons may be selected
• For this iteration, this module will only be implemented in the expanded scripture pane
  • For the current project only add a pencil to each verse (Note: other resources opened in the Scripture Pane cannot be edited, only the current project)
  • When a user clicks the pencil,
    • the Edit Verse module appears to the side of the verse
    • All other pencils are deactivated.
    • The user must complete the module or cancel out of it (i.e. the rest of the screen is disabled)

[da1nerd]

next button will be disabled until you begin editing.

[da1nerd]

@benjore will this reusable component be used just in other areas of scripture pane or do you plan on using it in other tools as well?

[benjore]

@neutrinog Other tools as well.

[cckozie]

Why does this have the QA/Retest label on it? It has never been through QA before.
I'm not seeing the edit option in the expanded scripture pane. It looks the same as it always has.

[da1nerd]

I'm not even done building this! lol

[da1nerd]

The UI for this is done. I'm waiting to hear back if there is an existing method of writing the data to the file.

[da1nerd]

@benjore when a verse is edited should all the alignments be reset? Should anything else be reset?

[benjore]

@neutrinog So if any part of a word is edited, the entire verse needs to be realigned. For selections in the tW tool, only reset the selection if the words in the selection have changed, otherwise keep the selection as is.

[da1nerd]

@benjore ah. Ok right now any time a verse is edited it will reset all the alignments for the entire verse no matter what tool you are in. You're telling me you don't want that functionality?
What happens then if they are working in tW and make an edit then move into the word alignment? Technically those alignments will be invalid no matter what tool you were in while making the edit.

[cckozie]

1. Italic and non-italic has been switched. Missing verses warning should be italicized and the rest not italicized as in the previous build:
   

2. Need to be able to edit missing verses.
   

3. Can you reduce the amount of white space above and below the pencil so that more verses can be seen in the window as in the UI mockup above?

4. There is very little difference in appearance in the Back button when it is disabled and enabled. Maybe if you remove the fill on the button and change font color as in the mockup the difference in state would be more obvious.

[PhotoNomad0]

@neutrinog @cckozie - localization broken for verse edit. Suspect integration with crowdin is not working.

[cckozie]

Need to verify that the problems noted in #4188 and #4212 are all dealt with when the above are fixed.

[richmahn]

Another issue I found with this: the change of addVerseEdit to editTargetVerse action function in VerseEditActions.js causes the Check pane's verse edit to not save and throw an error that addVerseEdit is not a function.

[da1nerd]

@richmahn there was actually a legacy action I left just in case something still needed it. I'll assign it to the correct action.

[cckozie]

translationCore 0.9.0 Travis build #7346 (from http://tc-release.unfoldingword.surge.sh/)
Now able to save edits.
Issues 1. Italics and non-italics, and 2. Edit missing verses from my comment "3 days ago" have not been address.
Also, there is missing localizations:

[da1nerd]

@cckozie these fixes were just merged in. They may not be in a build yet because the last couple of builds have timed out.