Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tN Tools #2009

Closed
8 tasks
benjore opened this issue Jun 28, 2017 · 6 comments
Closed
8 tasks

tN Tools #2009

benjore opened this issue Jun 28, 2017 · 6 comments

Comments

@benjore
Copy link

benjore commented Jun 28, 2017

Specs

Breakdown

  • [L] Parsing the TSV and generating the GroupIndex and GroupData (NPM Module)

    • parse during download
  • [M] Create the initial tN tool - tW tool with tN data (for testing SPIKES)

    • Fork tW to prove the concept that it works
  • [M] Verify (& fix as needed) that tN data is loaded correctly

  • [L] Use filesystem to handle parent and child categories for the tN tool card (include the hover-over description) - for each GL (part of NPM Module)

    • image
  • [M] Create Tool Card UI

  • [M] Add TSV parser to the Source Content Updater

  • [S] Add the tN data to the build process (getting the latest data from the Catalog)

  • Create tN tool

    • [4] SPIKE: what else needs to be done for tN to work.
    • [M] Update the Smurf Bar to display data from new location (alignment data)
  • [4] SPIKE: What needs to be done for tN quote highlight to show on the scripture pane.

Questions

  • How do we know the GL of the TSV file? Check the manifest
  • Suggestion: label the GL Language as not used (in the CSV file)
  • Should we add a Manifest file to the TSV file? There is already a manifest file, see this for example
    • Show the name of the tool?
    • Ability to add the a jpg for the tool logo?
    • Data version number?

Mockups

image

image

image

image

image

image

tN Categories.png

@benjore
Copy link
Author

benjore commented Jun 29, 2017

This issue probably makes #246 obsolete

@benjore
Copy link
Author

benjore commented Nov 5, 2018

All from original description:

  • translationNotes - Figures of Speech
  • translationNotes - Grammar
  • translationNotes - General

What needs to be learned

  • What to do when there is no tA article
  • What to do with General Information & Connecting Statement checks
  • What to do with links to [dead] cross references, links, blank articles

Blocker

  • Need: Original Languages quotes in the TSV (and preferably confirmed)
  • Parser to pivot/index categories/groups by support reference
    • Pull in tA article -
  • [ ]

Notes

  • Rather than separating the tN tool into several separate tools, make one big tool that can be internally filtered (based on user selection - probably in the tool card). In this way, it can be presented to the user as multiple tools. Use a single index regardless of visual approach.

@mannycolon
Copy link
Contributor

mannycolon commented Nov 6, 2018

Reference: https://github.com/translationCoreApps/tC_Resources/tree/master/resources/en/translationHelps/translationNotes/v0

Index file sample (Previously used)

[
  {
    "id": "figs_imperative",
    "name": "Imperatives - Other Uses"
  },
  {
    "id": "figs_merism",
    "name": "Merism"
  },
  {
    "id": "figs_activepassive",
    "name": "Active or Passive"
  },
  {
    "id": "figs_personification",
    "name": "Personification"
  },
  {
    "id": "figs_doublet",
    "name": "Doublet"
  },
  {
    "id": "figs_pronouns",
    "name": "Pronouns"
  }
]

Previous Group Data Item

[
  {
    "priority": 1,
    "comments": false,
    "reminders": false,
    "selections": false,
    "verseEdits": false,
    "contextId": {
      "information": "David calls himself \"your father\" because this is a very formal occasion. AT: \"my God\" (See: [[:en:ta:vol2:translate:figs_123person]])\n  ",
      "reference": { "bookId": "1ch", "chapter": 28, "verse": 9 },
      "tool": "translationNotes",
      "groupId": "figs_123person",
      "quote": "the God of your father",
      "occurrence": 1
    }
  }
]

@jag3773
Copy link
Contributor

jag3773 commented Nov 13, 2018

I added some comments in the Questions section.

@RoyalSix
Copy link

My branches:
tC: feature-bspidel-5756-2
tW: feature-bspidel-5756-3
tN: feature-bspidel-5756-2

@benjore benjore modified the milestones: tC Sprint #76, tC Sprint #77 Mar 19, 2019
@RoyalSix RoyalSix self-assigned this Mar 20, 2019
@benjore benjore modified the milestones: tC Sprint #77, tC Sprint #78 Apr 4, 2019
@benjore benjore modified the milestones: tC Sprint #78, tC Sprint #79 Apr 17, 2019
@cckozie
Copy link

cckozie commented Apr 27, 2019

Holding until all child issues pass.

@benjore benjore modified the milestones: tC Sprint #79, tC Sprint #81 May 22, 2019
@cckozie cckozie removed the QA/Hold label Jul 17, 2019
@cckozie cckozie closed this as completed Jul 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants