Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanded tW tool (Other Terms & Names) #2010

Closed
8 tasks done
benjore opened this issue Jun 28, 2017 · 14 comments
Closed
8 tasks done

Expanded tW tool (Other Terms & Names) #2010

benjore opened this issue Jun 28, 2017 · 14 comments

Comments

@benjore
Copy link

benjore commented Jun 28, 2017

User Story

As a checker, I want to more comprehensively check my translation so that I can be confident I'm using the correct words in my language

Specs

  • All three checkboxes are always visible on the tool card
  • By default, all three checkboxes are preselected
  • If the user unselects a a checkbox or two, save those settings (pegged to the project)
  • If all checkboxes are unselected, disable the Launch button
  • The progress bar is calculated based on what has been checked (e.g. if 87% of the Key Terms have been completed and only Key Terms is checked, then display 87% progress. If the user then checks all the boxes, but only 43% of all of them is completed, then show 43% progress.)
    • If it takes longer than 0.5 seconds to refresh the % complete, then show a little spinner on the progress bar (preferably where the % complete number is)
  • When the user clicks Launch, whatever checks correlate to the checkboxes are loaded in the tool.
  • If a Gateway Language does not have content for all the checkboxes, disable those.

Notes

  • See more still shows the tool description as per usual

Mockups

image

image

image

image

@benjore
Copy link
Author

benjore commented Jun 29, 2017

From jag3773 on 5/11/2017 "Content should be grabbed from https://api.door43.org/v3/catalog.json . The testing endpoint is https://test-api.door43.org/v3/catalog.json . This should all be in prod within a couple weeks."

Use https://api.door43.org/v3/subjects/Translation_Words.json

@benjore benjore changed the title tW Part II Expanded tW tool (Other Terms & Names) Oct 5, 2018
@benjore benjore added the Epic label Oct 9, 2018
@RoyalSix
Copy link

RoyalSix commented Nov 12, 2018

@benjore On a high level how do we determine a Gateway Language does not have all the content for a specific checkbox (type of check)?

Do we have a master list of all the info supposed to be in a check such as the Keyterms?

@mannycolon @jag3773

@mannycolon
Copy link
Contributor

@RoyalSix We could create the same list for tW as we mentioned for tN on #2009

Create JSON file to handle parent and child categories for the tN tool card (include the hover-over description) - for each GL

@jag3773
Copy link
Contributor

jag3773 commented Nov 13, 2018

@benjore @RoyalSix I'd suggest that if the other or names directories do not exist in a GL that the checkboxes be disabled. If those directories do exist, then enable the checkbox for that GL.

In conjunction, the tool should always fall back to the English tW entry if it missing in the GL. Given that older versions of tW may be published in the catalog, they may not have all the same content as the latest English, so the tool should be smart enough to fall back to English and not crash.

@benjore benjore added this to the tC Sprint #69 milestone Nov 13, 2018
@RoyalSix
Copy link

@benjore Do we want anything checked by default?

@RoyalSix
Copy link

RoyalSix commented Nov 14, 2018

What I have implemented so far is that the check boxes will dynamically be searched for and if the directory is there then it will show or else it will not.

i.e. If I remove the Hindi key terms resource then it will only show Other and Names.

If that functionality is not preferred then I can make a static list "Key Terms, Other, and Names" and then since we know what to expect everytime I can make them disabled. But if we take this approach then if new resources become available that are not on the list "Key Terms, Other, and Names" then the checks will not be available to show until we add them to the static list in the code.

Hope that makes sense.

Also note that I had to create a static list of names that convert to the display name
i.e. kt => "Key Terms", and other => "Other Terms" etc
These can be translated but theres no where I could find that tells me what kt should be shown as.

@cckozie
Copy link

cckozie commented Dec 19, 2018

1.1.0 (42d80de)
en_ulb_tit_book.zip

This happens when I load the project in tW with only Key Terms checked.
image

@RoyalSix
Copy link

RoyalSix commented Jan 1, 2019

Fixed in 8586b02

@cckozie
Copy link

cckozie commented Jan 2, 2019

1.1.0 (b287d3d)
fr_ulb_tit_book.zip

Still seeing problems when loading with only Key Terms selected. This does not always happen. I'm working on getting the sequence of events to reproduce. This appears to show the problem:
1.Shut down tD
2. Unzip the attached project into the projects folder
3. Start tC and select the project
4. Load the project in wA
5. Click on the tools icon in the menu bar to return to the tools page
6. Unclick the Other Terms and Names checkboxes
7. Load the project in tW and note the error

image

@RoyalSix
Copy link

RoyalSix commented Jan 7, 2019

@cckozie Having trouble recreating this. Going to investigate the error further.

@cckozie
Copy link

cckozie commented Jan 7, 2019

@RoyalSix I've been unable to reproduce this in the latest builds, so don't spend much time on it if the error doesn't tell you much.

@RoyalSix
Copy link

RoyalSix commented Jan 9, 2019

@cckozie Yea no luck for me. I guess I'll just put QA Retest on this one? Or should we close it

@RoyalSix RoyalSix added QA/Retest and removed QA/Fail labels Jan 9, 2019
@cckozie
Copy link

cckozie commented Jan 9, 2019

@RoyalSix Moving it to QA

@cckozie cckozie added QA/Pass and removed QA/Retest labels Jan 10, 2019
@cckozie
Copy link

cckozie commented Jan 10, 2019

All child issues have passed.

@benjore benjore closed this as completed Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants