Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OT aligning #3617

Closed
1 of 2 tasks
benjore opened this issue Jan 5, 2018 · 5 comments
Closed
1 of 2 tasks

Add support for OT aligning #3617

benjore opened this issue Jan 5, 2018 · 5 comments

Comments

@benjore
Copy link

benjore commented Jan 5, 2018

  • (M) Add importing OT projects
  • (M) Render alignment boxes RTL

image

@PhotoNomad0
Copy link
Contributor

@benjore - looking at your screenshot, 1:1 is not clear on UHB which side the chapter number is on. Typically in RTL support, the roman numerals are rendered in normal LTR within the overall RTL language. For example this would be wrong in the case of UHB pane:

screen shot 2018-11-14 at 4 30 56 pm

Can you clarify?

@cckozie

@benjore
Copy link
Author

benjore commented Nov 14, 2018

That is correct. LTR or RTL references should appear the same way, e.g. 1:2. The mock-up is incorrect.

@da1nerd
Copy link
Contributor

da1nerd commented Nov 16, 2018

The rtl rendering is covered by #3655

@da1nerd
Copy link
Contributor

da1nerd commented Nov 16, 2018

@PhotoNomad0 aren't you working on importing OT projects? Should this issue be assigned to you?

@benjore benjore added this to the tC Sprint #70 milestone Nov 27, 2018
@benjore benjore modified the milestones: tC Sprint #70, tC Sprint #71 Dec 11, 2018
@cckozie
Copy link

cckozie commented Dec 12, 2018

Tested in child issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants