Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Space before *paseq* U+05C0 isn't showing in Hebrew scripture pane. #7286

Closed
birchamp opened this issue Apr 12, 2022 · 15 comments
Closed

Space before *paseq* U+05C0 isn't showing in Hebrew scripture pane. #7286

birchamp opened this issue Apr 12, 2022 · 15 comments

Comments

@birchamp
Copy link
Contributor

birchamp commented Apr 12, 2022

Issue

In the UHB (for example EXO 7:19) the sequence is: final mem (U+05DD); regular space (U+0020); paseq (i.e. vertical line, U+05C0), but tC it omits the U+0020 when it displays the text.

DoD:

When a space occurs in the raw USFM before the paseq U+5C0 the space will be displayed and copiable into the clipboard.

Details

Video demonstrating the problem

@birchamp birchamp changed the title Space before *paseq* isn't showing in Hebrew scripture pane. Space before *paseq* U+05C0 isn't showing in Hebrew scripture pane. Apr 12, 2022
@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented May 11, 2022

Note:

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented May 17, 2022

@birchamp have a fix for this in usfm-js.

@PhotoNomad0
Copy link
Contributor

Note: before publish, Will need to regenerate bible content to pick up the fix.

@PhotoNomad0
Copy link
Contributor

New layout:
Screen Shot 2022-05-17 at 3 01 58 PM

@PhotoNomad0
Copy link
Contributor

When I copy from the scripture pane I now get עַֽל־ נַהֲרֹתָ֣⁠ם ׀ עַל־

@joeldruark
Copy link

Yes, this looks right. This problem exists in tC Create as well, just FYI

@PhotoNomad0
Copy link
Contributor

@birchamp - would you create PRs for GWE and TCC to update the version of usfm-js? It looks like the core of the fix is in scripture-resources-rcl which is still using a very old version of usfm-js. After updating the scripture-resources-rcl , we can update the version of scripture-resources-rcl used in GWE and TCC.

@PhotoNomad0
Copy link
Contributor

@elsylambert Fixed in translationCore 3.2.0 (b8de885) - in Exodus 7:19, the uhb should render as screenshot above.

@elsylambert
Copy link

translationCore 3.2.0 (b8de885).
-Online Imported Exodus project and opened wA.
-The Hebrew text in the scripture pane looks as in the screenshot below, without the space after paseq.
Screen Shot 2022-06-02 at 9 27 10 AM

Am I missing a step here? @PhotoNomad0

@PhotoNomad0
Copy link
Contributor

@elsylambert - very mysterious. It is working well for me. Which GL organization are you using? And which version of the UHB? I have selected D43 English and have this uhb: ~/translationCore/resources/hbo/bibles/uhb/v2.1.24_Door43-Catalog

@PhotoNomad0
Copy link
Contributor

@elsylambert - I also have ~/translationCore/resources/hbo/bibles/uhb/v2.1.24_unfoldingWord, which would be used for any other org. I tested with ru/ru_gl and it is also working.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jun 3, 2022

@elsylambert - OK I solved the mystery. when I installed on a clean PC, I see the same as you do. The uhb bundled with tCore was processed with the older tCore version and does not have the space. On my dev machine, I had processed the uhb with the updated tCore. I'll create a new build with reprocessed bibles. Since all the bundled bibles were processed with the older USFM-js that had the spacing bug.

@PhotoNomad0
Copy link
Contributor

@elsylambert - will need to delete the previous uhb before installing the new build (~/translationCore/resources/hbo/bibles/uhb). Fixed in translationCore 3.2.0 (82ee207)

@elsylambert
Copy link

Looks good in translationCore 3.2.0 (82ee207). Space before paseq is showing correctly in the latest tC build. It worked after deleting old uhb from the resource folder.
Screen Shot 2022-06-07 at 8 40 22 AM

@elsylambert
Copy link

Works well in translationCore 3.3.0 (fb96f72)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants