Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to Load Master branch resources to tCore Scripture pane. #7375

Closed
PhotoNomad0 opened this issue Jul 25, 2022 · 17 comments
Closed

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jul 25, 2022

Story Explanation

User Story

Add ability to Load Master branch resources to tCore Scripture pane.

We could add option to enter a repo URL to Scripture pane drop-down to read bible resources. This would input:

  • a tCore book repo that is for the same book of the bible as the current project
  • a whole bible repo that contains the book of the bible.

Also add a refresh button to three dot menu (with online warning)

To simplify implementation:

  • don't save data to disk, but just keep in memory for session. After user reopens tCore, when they open tool give prompt to user in scripture pane that they need to refresh the resource.
  • save URL to the USFM file into the repo manifest
  • could add an item to end of list - load from URL that would trigger tC to prompt for URL and validate.

We could do this as a patch for the 3.3.0 release.

Features / Specifications

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

@PhotoNomad0 PhotoNomad0 self-assigned this Aug 8, 2022
@PhotoNomad0
Copy link
Contributor Author

@birchamp @elsylambert OK need some suggestions on verbage. Here are the screenshots:

A.
Screen Shot 2022-08-08 at 9 45 44 PM

B.
Screen Shot 2022-08-08 at 9 46 08 PM

C.
Screen Shot 2022-08-08 at 9 47 51 PM

D.
Screen Shot 2022-08-08 at 9 47 51 PM

E.
Screen Shot 2022-08-08 at 9 58 02 PM

@PhotoNomad0
Copy link
Contributor Author

Replacement for B:

Screen Shot 2022-08-09 at 10 46 48 AM

@PhotoNomad0 PhotoNomad0 changed the title Collab Suggestion: Add ability to Load Master branch resources to tCore Scripture pane. Add ability to Load Master branch resources to tCore Scripture pane. Aug 10, 2022
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Aug 10, 2022

Added support for following URL formats:

  1. specific resource or project USFM file such as: https://git.door43.org/<owner>/<repo>/raw/branch/master/02-EXO.usfm or https://git.door43.org/ayan.75/bn_bgst_1ti_book/raw/branch/master/bn_bgst_1ti_book.usfm
  2. general repo with book lookup from manifest: https://git.door43.org/<owner>/<repo>

If exact load of URL fails, then will try to extract URL of repo from the start of the URL such as in # 2 and then lookup using manifest.

@elsylambert
Copy link

A. Load Bible Resource (USFM)
B. Project: en_ult_1ti_book
Enter Resource URL
C. Loading Resource : {URL}
D. What is the difference between C and D?
E. View Resource URL

@birchamp Please update/edit my suggestions when you get a chance.

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Aug 11, 2022

A. Load Bible Resource (USFM) B. Project: en_ult_1ti_book Enter Resource URL C. Loading Resource : {URL} D. What is the difference between C and D? E. View Resource URL

@birchamp Please update/edit my suggestions when you get a chance.

Oops, it looks like D was just a duplicate. @elsylambert

@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Aug 11, 2022

Note:
@elsylambert and I discussed E and decided to just put back the language ID in place of the VIEWURL.

@PhotoNomad0
Copy link
Contributor Author

@elsylambert Fix is in translationCore 3.3.0 (421972d).

There should be a separate issue(s) for next steps:

  • improved support in SP including being able to add Bible URL from SP add pane
  • fix issue that the remove resource menu item does not work on the URL Bible panes.
    @birchamp

@elsylambert
Copy link

elsylambert commented Aug 15, 2022

@PhotoNomad0
A. I added the USFM for tit :https://git.door43.org/Es-419_gl/es-419_glt/raw/branch/master/57-TIT.usfm, it shows in a TIT project, but I am not able to remove the Resource from the Scripture Pane.

@elsylambert
Copy link

elsylambert commented Aug 15, 2022

For your review: B. Console shows error that Locale is missing
Screen Shot 2022-08-15 at 1 46 07 PM
.

@elsylambert
Copy link

elsylambert commented Aug 15, 2022

C. I mistakenly was trying to load a Ruth USFM to a EST project. At first, it went fine but showed nothing in the SP. Then I tried again and it showed the following error:
Screen Shot 2022-08-15 at 1 40 36 PM

The error message is missing the text in {}.

@PhotoNomad0
Copy link
Contributor Author

@PhotoNomad0 A. I added the USFM for tit :https://git.door43.org/Es-419_gl/es-419_glt/raw/branch/master/57-TIT.usfm, it shows in a TIT project, but I am not able to remove the Resource from the Scripture Pane.

Yes, as stated above that is a known issue. We need to create separate issue(s) for next steps:

  • improved support in SP including being able to add Bible URL from SP add pane
  • fix issue that the remove resource menu item does not work on the URL Bible panes.
    @birchamp

@PhotoNomad0
Copy link
Contributor Author

For your review: B. Console shows error that Locale is missing Screen Shot 2022-08-15 at 1 46 07 PM .

I've seen that before, but not able to reproduce that in the latest build.

@PhotoNomad0
Copy link
Contributor Author

C. I mistakenly was trying to load a Ruth USFM to a EST project. At first, it went fine but showed nothing in the SP. Then I tried again and it showed the following error: Screen Shot 2022-08-15 at 1 40 36 PM

The error message is missing the text in {}.

Yes, I see the broken error message. I cannot reproduce the problem that it does not show an error the first time.

@PhotoNomad0
Copy link
Contributor Author

@PhotoNomad0
Copy link
Contributor Author

C. I mistakenly was trying to load a Ruth USFM to a EST project. At first, it went fine but showed nothing in the SP. Then I tried again and it showed the following error: Screen Shot 2022-08-15 at 1 40 36 PM
The error message is missing the text in {}.

Yes, I see the broken error message. I cannot reproduce the problem that it does not show an error the first time.

OK, I saw that happen once, very strange... @elsylambert

@elsylambert
Copy link

translationCore 3.3.0 (df4a8a6). The issue C. is resolved. tC gives the correct error message when a different USFM(Book) is loaded into the a Project(different from the Manifest). User is able to delete the USFM Resource from the ADD Resource Modal. Remove Resource option is no longer available for the USFM Resource in Scripture Pane.

@elsylambert
Copy link

Wrote up #7403 for a minor UI issue with the Resource title in expanded scripture pane.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants