Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export with alignments fails in tCore which also breaks upload #7511

Closed
PhotoNomad0 opened this issue Jul 5, 2023 · 3 comments
Closed

Export with alignments fails in tCore which also breaks upload #7511

PhotoNomad0 opened this issue Jul 5, 2023 · 3 comments
Assignees
Labels

Comments

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Jul 5, 2023

Story Explanation

User Story

Export with alignments fails in tCore which also breaks upload. It also affects uploading to D43 (which also exports to USFM before upload). Seems to be related to verse spans. Perhaps those that were partially aligned before verse span alignment was added.

To reproduce try exporting this project:

https://app.zenhub.com/files/65028237/981a55a4-86ab-4300-b4ee-df431be93290/download

Features / Specifications

  • [ ]
  • [ ]
  • [ ]

Definition of Done

  • [ ]
  • [ ]
  • [ ]

Additional Context

Mockups

@PhotoNomad0 PhotoNomad0 self-assigned this Jul 5, 2023
@PhotoNomad0
Copy link
Contributor Author

PhotoNomad0 commented Jul 6, 2023

@elsylambert @danielklapp - The fix is in translationCore 3.5.0 (30831db).

When testing with the above project - if before opening the project, you export to USFM with alignments. Then you will now see a warning that alignments have been invalidated. If you click on export. Then will see that alignments being updated for Num 5:12, 5:13, and 5:20. And then will get the file dialog to select where to save the file.

@PhotoNomad0
Copy link
Contributor Author

Note:

the exceptions thrown in old tC versions are related to the empty verses in ch 5 - 12,13,20,21

@elsylambert
Copy link

@PhotoNomad0 Testing in translationCore 3.5.0 (30831db) with the above mentioned steps and the above project. When exported to USFM with alignments., before opening the project, saw a warning that alignments have been invalidated>clicked on export and then saw that alignments were updated for Num 5:12, 5:13, and 5:20. After that I got the file dialog to select where to save the file.
Screenshot 2023-07-11 at 10 38 44 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants