Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC shows tC-ready content in the source content downloader #7604

Closed
elsylambert opened this issue Dec 10, 2024 · 9 comments
Closed

TC shows tC-ready content in the source content downloader #7604

elsylambert opened this issue Dec 10, 2024 · 9 comments
Assignees
Labels

Comments

@elsylambert
Copy link

elsylambert commented Dec 10, 2024

We need to show tC-ready resources by default and use a check box to show all resources.

  • Bundled resources are filtered by tc-ready resources for Max and Min installs
    image
@birchamp
Copy link
Contributor

We should try testing what will happen without making changes to how we access Door43-catalog items.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Dec 11, 2024

I tested tCore without door43-catalog content in the bundle. When I open projects that were started with GL from door43-catalog, then tCore crashes. It seems it would be a lot of work to add detection of the missing GL content and adding a popup to warn the user and give them the option switch the project to unfoldingWord GL or give them option to download the correct door43-catalog GL. So currently I am still bundling the door43-catalog original language bibles and en resources in the build.

@PhotoNomad0
Copy link
Contributor

@elsylambert Implemented in develop build Version 3.6.7 (4bde355)

Not seeing much size difference between LITE and MAX builds now.since we only have a few tc-ready repos.

@PhotoNomad0
Copy link
Contributor

Example Install Size comparisons:

  1. Without tc-ready support:
Screenshot 2024-12-12 at 6 07 01 AM
  1. With tc-ready content only:
Screenshot 2024-12-12 at 6 07 48 AM

@birchamp @elsylambert

@elsylambert
Copy link
Author

Verified in translationCore 3.6.7 (4b44c06). tc-ready resources are shown by the content update dialog by default. Toggle to show All content displays all other resources. Works as expected.
@PhotoNomad0 The tool tip on the Show all content toggle button is missing, as it is in the mockup.

@PhotoNomad0
Copy link
Contributor

PhotoNomad0 commented Dec 18, 2024

Verified in translationCore 3.6.7 (4b44c06). tc-ready resources are shown by the content update dialog by default. Toggle to show All content displays all other resources. Works as expected. @PhotoNomad0 The tool tip on the Show all content toggle button is missing, as it is in the mockup.

@elsylambert The text in the mockup implies that there is different message for when the toggle is switched on. What would that text be?

@elsylambert
Copy link
Author

When switched on it should say “The list shows all available content ”

@PhotoNomad0
Copy link
Contributor

@elsylambert There is fixed in a new release build translationCore 3.6.7 (a5b157d)

@elsylambert
Copy link
Author

Verified in translationCore 3.6.7 (a5b157d). Tool tip on the toggle button looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants