Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOWNLOAD_URL is hardcoded to include only the aws-cli package for x86. #8

Closed
2000yeshu opened this issue Nov 9, 2021 · 3 comments
Closed

DOWNLOAD_URL is hardcoded to include only the aws-cli package for x86. #8

2000yeshu opened this issue Nov 9, 2021 · 3 comments

Comments

@2000yeshu
Copy link

2000yeshu commented Nov 9, 2021 •
edited
Loading

I want to install aws cli on an arm instance. Looking at the code, it would help if you inherit DOWNLOAD_URL(optional) from yml environment variables just like AWS_CLI_VERSION. That way we can provide the aws cli package URL in the workflow file itself(amd or arm). Or just have an env variable like ARCH with possible values of arm and amd.

https://aws.amazon.com/blogs/developer/aws-cli-v2-now-available-for-linux-arm/
@2000yeshu
Copy link
Author

Happy to create a PR. Cheers

@2000yeshu
Copy link
Author

Good work BTW :)

@unfor19
Copy link
Owner

unfor19 commented Nov 10, 2021

@2000yeshu great suggestion, feel free to create a PR
Otherwise I'll add it myself

@unfor19 unfor19 mentioned this issue Nov 12, 2021
Merged
@unfor19 unfor19 closed this as completed Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@unfor19 @2000yeshu