CLDR-17658 Virtual scroller for Dashboard #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btangmu
changed the title
btangmu
changed the title
btangmu
changed the title
- Use vue-virtual-scroller - Remove recently added CATS_ONE_PER_PAGE feature
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
btangmu
commented
Jun 5, 2024
| @@ -48,6 +48,7 @@ | |||
| "marked": "^4.3.0", | |||
| "swagger-client": "^3.26.7", | |||
| "vue": "^3.2.47", | |||
| "vue-virtual-scroller": "^2.0.0-beta.8", | |||
There was a problem hiding this comment.
IMPORTANT: this is a "beta" version
|
This is deployed on cldr-staging currently |
srl295
approved these changes
Jun 5, 2024
|
performance seems great. A little blinky, perhaps the controls at the top are being more dynamic than they need to be? |
I've noticed for a while now that sometimes the header appears then disappears then reappears -- if that's what you mean by "blinky", it's annoying and predates the virtual scroller; something about the sequence of events while loading, maybe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-17658
ALLOW_MANY_COMMITS=true