Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fallible operations in zerovec #1081

Open
Tracked by #1082
Manishearth opened this issue Sep 22, 2021 · 1 comment
Open
Tracked by #1082

Fallible operations in zerovec #1081

Manishearth opened this issue Sep 22, 2021 · 1 comment
Assignees
@sffc
Labels
blocked A dependency must be resolved before this is actionable C-zerovec Component: Yoke, ZeroVec, DataBake help wanted Issue needs an assignee S-medium Size: Less than a week (larger bug fix or enhancement)
Milestone
Utilities 1.0

Comments

@Manishearth
Copy link
Member

Manishearth commented Sep 22, 2021 •
edited
Loading

Part of #1082

The zerovec crate has a bunch of operations which may panic, specifically most of the mutation operations as well as VarZeroVec construction operations where the final slice may be larger than a u32 in length.

We should have fallible APIs; perhaps making them the default.
@Manishearth Manishearth added help wanted Issue needs an assignee C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) labels Sep 22, 2021
This was referenced Sep 22, 2021
Closed
Merged
@Manishearth Manishearth self-assigned this Sep 27, 2021
@Manishearth Manishearth added this to the ICU4X 0.5 milestone Sep 27, 2021
@Manishearth Manishearth modified the milestones: ICU4X 0.5, ICU4X 0.6 Jan 24, 2022
@Manishearth
Copy link
Member Author

This would be obviated by #1443 which is likely to happen. Keeping the issue open anyway until that is fixed

@Manishearth Manishearth added the blocked A dependency must be resolved before this is actionable label Mar 9, 2022
@Manishearth Manishearth removed their assignment May 23, 2022
@sffc sffc self-assigned this May 25, 2022
@sffc sffc modified the milestones: ICU4X 0.6, ICU4X 1.0 (Features) May 25, 2022
@sffc sffc added C-zerovec Component: Yoke, ZeroVec, DataBake and removed C-data-infra Component: provider, datagen, fallback, adapters labels Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sffc sffc

Labels
blocked A dependency must be resolved before this is actionable C-zerovec Component: Yoke, ZeroVec, DataBake help wanted Issue needs an assignee S-medium Size: Less than a week (larger bug fix or enhancement)
Projects
None yet
Milestone
Utilities 1.0
Development

No branches or pull requests
2 participants
@sffc @Manishearth