-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Default implementation for date data #260
Comments
Depends on #257 |
This comment has been minimized.
This comment has been minimized.
I think we should hard-code this into the source file. This is only last-resort data. We don't necessarily need to enforce that it stays up-to-date with root.json; that could be another task for later. |
@sffc Which date data is being referred to here? |
All data structures related to dates, in order to perform date formatting if locale data is unavailable |
Makes sense, thanks! @samchen61661 this would be anything tagged
You can find a lot of the root data in https://unicode-org.github.io/cldr-staging/charts/latest/summary/root.html , though it's a bit unwieldy to work with |
Thanks for explaining! In order to move forward, I might need to know what would be the default local and its metadata mapping which will be used in the date time structures. I checked https://unicode-org.github.io/cldr-staging/charts/latest/summary/root.html, and it contains lots of information. Need to find an efficient way to figure out the value mapping. |
Let's hold off on this until @zbraniecki's DateTime refactoring lands. |
We should do this once all the datetime data refactoring is done. |
Do we still want to do this after the decision in #1494 (comment)? |
I'd say no, and we can close this. @sffc ? |
Given the additional further discussion in #2174, we can close this. |
We should build a
Default
implementation for date data based on root.json.The text was updated successfully, but these errors were encountered: