Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better Default implementation for date data #260

Closed
sffc opened this issue Sep 22, 2020 · 12 comments
Closed

Better Default implementation for date data #260

sffc opened this issue Sep 22, 2020 · 12 comments
Labels
blocked A dependency must be resolved before this is actionable C-datetime Component: datetime, calendars, time zones R-as-designed Resolution: By design principles, this won't be fixed S-small Size: One afternoon (small bug fix or enhancement) T-enhancement Type: Nice-to-have but not required

Comments

@sffc
Copy link
Member

sffc commented Sep 22, 2020

We should build a Default implementation for date data based on root.json.

@sffc sffc added T-enhancement Type: Nice-to-have but not required C-datetime Component: datetime, calendars, time zones labels Sep 22, 2020
@zbraniecki zbraniecki added this to the 2020 Q4 milestone Sep 24, 2020
@sffc
Copy link
Member Author

sffc commented Dec 9, 2020

Depends on #257

@sffc sffc added the blocked A dependency must be resolved before this is actionable label Dec 9, 2020
@sffc sffc modified the milestones: 2020 Q4, 2021-Q1-m1 Jan 7, 2021
@sffc sffc modified the milestones: 2021-Q1-m1, ICU4X 0.2 Feb 3, 2021
@sffc sffc modified the milestones: ICU4X 0.2, 2021-Q2-m1 Mar 25, 2021
@sffc sffc added the S-small Size: One afternoon (small bug fix or enhancement) label Apr 3, 2021
@sffc sffc modified the milestones: 2021-Q2-m1, ICU4X 0.3 Apr 19, 2021
@dminor

This comment has been minimized.

@sffc sffc modified the milestones: ICU4X 0.3, ICU4X 0.4 Jul 13, 2021
@sffc sffc removed their assignment Aug 11, 2021
@sffc sffc removed the blocked A dependency must be resolved before this is actionable label Aug 11, 2021
@sffc
Copy link
Member Author

sffc commented Aug 12, 2021

I think we should hard-code this into the source file. This is only last-resort data. We don't necessarily need to enforce that it stays up-to-date with root.json; that could be another task for later.

@sffc sffc modified the milestones: ICU4X 0.4, ICU4X 0.5 Aug 12, 2021
@sffc sffc added the help wanted Issue needs an assignee label Aug 12, 2021
@Manishearth
Copy link
Member

@sffc Which date data is being referred to here?

@sffc
Copy link
Member Author

sffc commented Oct 12, 2021

All data structures related to dates, in order to perform date formatting if locale data is unavailable

@Manishearth
Copy link
Member

Makes sense, thanks! @samchen61661 this would be anything tagged #[data_struct] in the datetime component, e.g.

#[icu_provider::data_struct]

You can find a lot of the root data in https://unicode-org.github.io/cldr-staging/charts/latest/summary/root.html , though it's a bit unwieldy to work with

@samchen61661
Copy link
Member

Thanks for explaining!

In order to move forward, I might need to know what would be the default local and its metadata mapping which will be used in the date time structures.

I checked https://unicode-org.github.io/cldr-staging/charts/latest/summary/root.html, and it contains lots of information. Need to find an efficient way to figure out the value mapping.

@sffc
Copy link
Member Author

sffc commented Oct 22, 2021

Let's hold off on this until @zbraniecki's DateTime refactoring lands.

@sffc sffc added the blocked A dependency must be resolved before this is actionable label Jan 27, 2022
@sffc sffc modified the milestones: ICU4X 0.5, ICU4X 1.0 Jan 27, 2022
@sffc
Copy link
Member Author

sffc commented Jan 27, 2022

We should do this once all the datetime data refactoring is done.

@robertbastian
Copy link
Member

Do we still want to do this after the decision in #1494 (comment)?

@Manishearth
Copy link
Member

I'd say no, and we can close this. @sffc ?

@sffc
Copy link
Member Author

sffc commented Jul 14, 2022

Given the additional further discussion in #2174, we can close this.

@sffc sffc closed this as not planned Won't fix, can't repro, duplicate, stale Jul 14, 2022
@sffc sffc added R-as-designed Resolution: By design principles, this won't be fixed and removed help wanted Issue needs an assignee labels Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked A dependency must be resolved before this is actionable C-datetime Component: datetime, calendars, time zones R-as-designed Resolution: By design principles, this won't be fixed S-small Size: One afternoon (small bug fix or enhancement) T-enhancement Type: Nice-to-have but not required
Projects
None yet
Development

No branches or pull requests

6 participants