Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more generics in datetime symbols code #3771

Open
1 of 5 tasks
Manishearth opened this issue Aug 3, 2023 · 1 comment
Open
1 of 5 tasks

Use more generics in datetime symbols code #3771

Manishearth opened this issue Aug 3, 2023 · 1 comment
Labels
C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement)

Comments

@Manishearth
Copy link
Member

Manishearth commented Aug 3, 2023

Currently we use a pile of macros to define datetime symbols provider structs and datetime symbols datagen, defining this tree of "format vs standalone" + short/wide/narrow/abbreviated for each.

This is annoying to evolve, hard to debug, and leads to a proliferation of similar types. It would be nice to use generic code instead, with some internal traits to help implementation.

Most of these changes are internal aside from provider changes

Tracking:

@sffc
Copy link
Member

sffc commented Oct 5, 2023

Might be obsoleted by #3865

@sffc sffc added this to the Backlog ⟨P4⟩ milestone Oct 5, 2023
@sffc sffc added C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement) labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-datetime Component: datetime, calendars, time zones S-medium Size: Less than a week (larger bug fix or enhancement)
Projects
None yet
Development

No branches or pull requests

2 participants