Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser needs to be fixed in order to parse all the CLDR units. #4461

Closed
younies opened this issue Dec 15, 2023 · 0 comments · Fixed by #4418
Closed

Parser needs to be fixed in order to parse all the CLDR units. #4461

younies opened this issue Dec 15, 2023 · 0 comments · Fixed by #4418

Comments

@younies
Copy link
Member

younies commented Dec 15, 2023

There are many CLDR units that the MeasureUnitParser is not parsing:

Such as:

    let non_parsable_units: HashSet<&str> = [
        "g-force",
        "arc-second",
        "arc-minute",
        "bu-jp",
        "se-jp",
        "liter-per-100-kilometer",
        "mile-per-gallon-imperial",
        "day-person",
        "week-person",
        "pound-force-foot",
        "calorie-it",
        "british-thermal-unit",
        "british-thermal-unit-it",
        "therm-us",
        "pound-force",
        "kilogram-force",
        "kilowatt-hour-per-100-kilometer",
        "shaku-length",
        "shaku-cloth",
        "jo-jp",
        "ri-jp",
        "nautical-mile",
        "mile-scandinavian",
        "100-kilometer",
        "earth-radius",
        "solar-radius",
        "astronomical-unit",
        "light-year",
        "ounce-troy",
        "earth-mass",
        "solar-mass",
        "solar-luminosity",
        "pound-force-per-square-inch",
        "gasoline-energy-density",
        "dessert-spoon",
        "dessert-spoon-imperial",
        "fluid-ounce-imperial",
        "fluid-ounce",
        "cup-jp",
        "cup-metric",
        "pint-metric",
        "pint-imperial",
        "quart-imperial",
        "gallon-imperial",
        "to-jp",
        "month-person",
        "year-person",
        "decade",
    ]

Therefore, the parser needs to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant