Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plug uprops into icu4x-datagen and add examples using icu_testdata::get_provider() #936

Closed
Tracked by #148
iainireland opened this issue Aug 5, 2021 · 3 comments · Fixed by #1204
Closed
Tracked by #148
Assignees
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Milestone

Comments

@iainireland
Copy link
Contributor

Following up on the minimal uprops provider work in issue #882 and issue #883, we should:

  1. Add support in icu4x-datagen (somewhat complicated by the fact that compiling and running an ICU4C tool is necessary)
  2. Add example in icu_uniset::props
@sffc
Copy link
Member

sffc commented Aug 5, 2021

  1. Add support in icu4x-datagen (somewhat complicated by the fact that compiling and running an ICU4C tool is necessary)

No, we should not depend on ICU4C being run. The idea is that ICU4C ships a zip file with all the properties pre-exported. For the time being, icu4x-datagen should take a path to that directory, with instructions on how to generate it manually, and eventually (later this quarter or in Q4) you will be able to download that directory as a zip file from GitHub.

@iainireland iainireland added C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality labels Aug 11, 2021
@sffc sffc added this to the ICU4X 0.4 milestone Aug 26, 2021
@iainireland
Copy link
Contributor Author

Zip file export is being added to ICU4C here: unicode-org/icu#1857.

@sffc sffc changed the title Improve uprops data pipeline Plug uprops into icu4x-datagen and add examples using icu_testdata::get_provider() Oct 19, 2021
@sffc
Copy link
Member

sffc commented Oct 19, 2021

We need to add uprops to icu4x-datagen and then follow up shortly thereafter (or in the same PR) with crate-level and property-level examples in icu_properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-data-infra Component: provider, datagen, fallback, adapters S-medium Size: Less than a week (larger bug fix or enhancement) T-core Type: Required functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants