Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Display impl for AugmentedScriptSet #21

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Add Display impl for AugmentedScriptSet #21

merged 2 commits into from
Jun 24, 2020

Conversation

Manishearth
Copy link
Member

@Manishearth Manishearth mentioned this pull request Jun 23, 2020
Merged
@crlf0710
Copy link
Collaborator

Fixed a small typo and added a unit test. Do we want to use comma to separate the items here, or use the plus mentioned in #72770 ?

@crlf0710
Copy link
Collaborator

By the way, I'm also a little tempted to use "Chinese" instead of "Han with Bopomofo" :)

@Manishearth
Copy link
Member Author

Plus is fine too

@Manishearth
Copy link
Member Author

I'm using the official spec name for it

@Manishearth Manishearth merged commit 233de0a into master Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Manishearth @crlf0710