Handle more data types when parsing dataset.xml #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failing on docs? |
|
That should fix it, let's see... |
|
|
lesserwhirls
force-pushed
the
typedData
branch
6 times, most recently
from
fc2f3b9
to
a70cc45
Compare
|
I did a boo boo @dopplershift. You fixed the docs and pushed a commit...I forgot you did that and used |
They changed a config option on us.
|
I still had it, not that it was a hard change. |
|
Sorry about that... |
|
Apparently there's a new version of flake8-comprehensions out--I've pushed cleanups for the new lint. |
dopplershift
approved these changes
May 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before these changes, we only handled types
intandfloatwhen parsing dataset.xml - everything else was left as a string and logged a warning. Even with this PR, we still do not handle:because I do not have an example of those, and honestly have no idea what to do with some.