Fix build #129
Fix build #129
Conversation
dopplershift
commented
May 23, 2017
dopplershift
commented
- Fix up config so flake8-quotes runs correctly
- Clean up docstrings and enable flake8-docstrings
- Move to using pytest-catchlog to capture and test log messages (this seems better supported and is recommended from Capturing, with and without stdlib logging pytest-dev/pytest#2079). Pytest 3.1 broke our current handling.
dopplershift
force-pushed
the
fix-build
branch
3 times, most recently
from
6f193e5
to
edd87ae
Compare
|
Sphinx gallery fails due to Unicode problems. I'm waiting to see the resolution of sphinx-gallery/sphinx-gallery#246 before I decide whether to disable our windows doc builds, and hence example runs. |
0.10.0 supports multiline, but accidentally changed the defaults. Just go ahead and specify.
dopplershift
force-pushed
the
fix-build
branch
2 times, most recently
from
bc42990
to
53108d3
Compare
|
@lesserwhirls @jrleeman One of you want to look this over? It passed before I rebased. Need this to go in before I do my next big PR with our API updates. |
|
Having a look now. |
| @@ -1,6 +1,7 @@ | |||
| # Copyright (c) 2013-2015 University Corporation for Atmospheric Research/Unidata. | |||
| # Distributed under the terms of the MIT License. | |||
| # SPDX-License-Identifier: MIT | |||
| """Tools for accessing atmospheric and oceanic science data on remote servers.""" | |||
There was a problem hiding this comment.
Isn't AOS a bit limited considering lots of folks run THREDDS? But then again this isn't a THREDDS specific library. Maybe something like : Tools for accessing remote data hosted on THREDDS and other servers? Maybe that's too general?
There was a problem hiding this comment.
The only TDSs I've encountered in the wild are AOS. I'd say it's ok for now, especially since it is kind of the target audience, and siphon is still pretty unknown (I think).
siphon/cdmr/coveragedataset.py
Outdated
| @@ -1,6 +1,7 @@ | |||
| # Copyright (c) 2016 University Corporation for Atmospheric Research/Unidata. | |||
| # Distributed under the terms of the MIT License. | |||
| # SPDX-License-Identifier: MIT | |||
| """Provide access to TDS' Coverage Dataset.""" | |||
There was a problem hiding this comment.
TDS' took me a couple of glances. Maybe this reads cleaner? Provide access to a THREEDS server's coverage dataset
There was a problem hiding this comment.
Yeah, it does look odd. Maybe "Provide access to a TDS Coverage Dataset."
| @@ -335,15 +337,14 @@ def make_access_urls(self, catalog_url, all_services, metadata=None): | |||
| self.access_urls = access_urls | |||
|
|
|||
| def add_access_element_info(self, access_element): | |||
| """Create an access method from a catalog element.""" | |||
There was a problem hiding this comment.
Why is it that sometimes we use a regular string
"""blah blah blah"""
but others, we use a raw string (like line 347 below)
r"""blah blah blah"""
There was a problem hiding this comment.
At some point I was in the habit of using raw to make sure LaTeX math renders properly. Not really needed here.
There was a problem hiding this comment.
I may have added some of them as well, no biggie.
|
Should have done this as a review, not single comments...sorry about that. |
This gets us a clean pass with flake8-docstrings.
Pytest 3.1.0 broke our current use of capfd, but that doesn't seem to be a good way to handle capturing of log messages. (pytest-dev/pytest#2079) So instead use pytest-catchlog, which was recommended in that issue and seems to be maintained.
Need to wait until sphinx-gallery has a release with sphinx-gallery/sphinx-gallery#246 in it.
Instead of passing the increment and calculated end to numpy.arange(), just make a range of integers out to the number of points, multiply by inc, and add start. Also fixes small bug where tolist() was called on array, but results were not saved anywhere.
|
@jrleeman you may want to look over the last commit. |
