Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Instance Methods to JAX Frontend #3617

Open
iamjameskeane opened this issue Aug 25, 2022 · 8 comments
Open

Add Instance Methods to JAX Frontend #3617

iamjameskeane opened this issue Aug 25, 2022 · 8 comments
Assignees
Labels
hacktoberfest hacktoberfest JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist ToDo A ToDo list of tasks

Comments

@iamjameskeane
Copy link
Contributor

iamjameskeane commented Aug 25, 2022

Add Instance Methods to JAX Frontend

_

Please keep in mind that the proper way to link an issue to this list is to comment "- [ ] #issue_number" while the issue's title only includes the name of the function you've chosen.
_

The main file paths where these functions are likely to be added are:

ivy/functional/frontends/jax/devicearray.py
ivy\_tests/test\_ivy/test\_frontends/test\_jax/test\_devicearray.py
ivy\_tests/test\_ivy/test\_frontends/test\_jax/test\_jax\_devicearray.py
ivy/functional/frontends/jax/array.py
ivy\_tests/test\_ivy/test\_frontends/test\_jax/test\_array.py
ivy/functional/frontends/jax/numpy/mathematical\_functions.py

@iamjameskeane iamjameskeane added Extension JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist ToDo A ToDo list of tasks labels Aug 25, 2022
@iamjameskeane iamjameskeane closed this as not planned Won't fix, can't repro, duplicate, stale Aug 26, 2022
@iamjameskeane iamjameskeane reopened this Sep 9, 2022
@ivy-llc ivy-llc deleted a comment from devsugun Sep 20, 2022
@ivy-llc ivy-llc deleted a comment from Adityahulk Oct 17, 2022
@R-E-yawn R-E-yawn mentioned this issue Nov 6, 2022
@fnhirwa fnhirwa self-assigned this Nov 20, 2022
@ivy-llc ivy-llc deleted a comment from FaikYY Nov 25, 2022
@ivy-llc ivy-llc deleted a comment from SaifAshraf70 Nov 29, 2022
@ivy-llc ivy-llc deleted a comment from xoiga123 Mar 9, 2023
@RakshitKumar04
Copy link
Contributor

Hey, @hirwa-nshuti can we work on these to-dos?

@fnhirwa
Copy link
Contributor

fnhirwa commented Mar 29, 2023

Hey @RakshitKumar04 feel free to work on them they’re open for contributions

@ivy-llc ivy-llc deleted a comment from shireenchand Mar 29, 2023
@ivy-llc ivy-llc deleted a comment from rodlaf Apr 2, 2023
@ivy-llc ivy-llc deleted a comment from Sheila-nk Apr 5, 2023
@ivy-llc ivy-llc deleted a comment from felixreynoso Apr 9, 2023
@ivy-llc ivy-llc deleted a comment from RakshitKumar04 Apr 14, 2023
@ivy-llc ivy-llc deleted a comment from RakshitKumar04 Apr 14, 2023
@iamravi1 iamravi1 mentioned this issue Apr 17, 2023
@umairjavaid
Copy link
Contributor

umairjavaid commented Apr 25, 2023

add cummin to this list please doc

@ivy-llc ivy-llc deleted a comment from fahad12398 May 1, 2023
@ivy-llc ivy-llc deleted a comment from VictorOdede May 3, 2023
@ivy-llc ivy-llc deleted a comment from VictorOdede May 4, 2023
@ivy-llc ivy-llc deleted a comment from VictorOdede May 4, 2023
@ivy-llc ivy-llc deleted a comment from samthakur587 Jul 4, 2023
@ivy-llc ivy-llc deleted a comment from samthakur587 Jul 4, 2023
@ivy-llc ivy-llc deleted a comment from MuhammadNizamani Jul 8, 2023
@ivy-llc ivy-llc deleted a comment from MuhammadNizamani Jul 9, 2023
@ivy-llc ivy-llc deleted a comment from MuhammadNizamani Jul 11, 2023
@ivy-llc ivy-llc deleted a comment from MuhammadNizamani Jul 13, 2023
@ivy-llc ivy-llc deleted a comment from VictorOdede Jul 14, 2023
@ivy-llc ivy-llc deleted a comment from VictorOdede Jul 14, 2023
@ivy-llc ivy-llc deleted a comment from seemanitharwal Jul 19, 2023
@ivy-llc ivy-llc deleted a comment from shakikk Jul 20, 2023
@seemanitharwal
Copy link
Contributor

@ivy-llc ivy-llc deleted a comment from BrolyDBZ Jul 30, 2023
@ivy-llc ivy-llc deleted a comment from jindalai Aug 4, 2023
@ivy-llc ivy-llc deleted a comment from jyjoshi Aug 15, 2023
@ivy-llc ivy-llc deleted a comment from AdityaGoel01 Aug 21, 2023
@ivy-leaves ivy-leaves assigned Ishticode and unassigned fnhirwa Aug 22, 2023
@AbdullahSabry
Copy link
Contributor

@ivy-llc ivy-llc deleted a comment from vincenzofanizza Sep 6, 2023
@ivy-llc ivy-llc deleted a comment from gauthamk02 Sep 6, 2023
@ivy-llc ivy-llc deleted a comment from mcnugets Sep 19, 2023
@ivy-llc ivy-llc deleted a comment from Mghrabi Sep 21, 2023
@ivy-llc ivy-llc deleted a comment from ChibuezeOnejeme Sep 21, 2023
@a0m0rajab a0m0rajab added the hacktoberfest hacktoberfest label Sep 25, 2023
@akshatvishu
Copy link
Contributor

akshatvishu commented Oct 2, 2023

@Ishticode @jkeane508 I don't think split is available as an instance method at jax and thus, should be removed from this list.

refs:https://github.com/google/jax/blob/4471abe1c6874a650a60a975d9e9dd21b010f059/jax/_src/basearray.pyi#L119

@AnnaTz
Copy link
Contributor

AnnaTz commented Oct 2, 2023

@Ishticode @jkeane508 I don't think split is available as an instance method at jax and thus, should be removed from this list.

refs:https://github.com/google/jax/blob/4471abe1c6874a650a60a975d9e9dd21b010f059/jax/_src/basearray.pyi#L119

You are right. I removed it. along with some others that should not exist either.
Thanks!

@mcnugets
Copy link
Contributor

mcnugets commented Oct 2, 2023

@Ishticode @jkeane508 I don't think split is available as an instance method at jax and thus, should be removed from this list.
refs:https://github.com/google/jax/blob/4471abe1c6874a650a60a975d9e9dd21b010f059/jax/_src/basearray.pyi#L119

You are right. I removed it. along with some others that should not exist either. Thanks!

I was attempting to implement the split instance method, and couldn't fix reoccurring test errors, but I guess this resolves it. Thank you @AnnaTz

@ivy-llc ivy-llc deleted a comment from mcnugets Oct 3, 2023
@ivy-llc ivy-llc locked and limited conversation to collaborators Jan 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
hacktoberfest hacktoberfest JAX Frontend Developing the JAX Frontend, checklist triggered by commenting add_frontend_checklist ToDo A ToDo list of tasks
Projects
None yet
Development

No branches or pull requests