Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added floor function to numpy frontend #12948

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Added floor function to numpy frontend #12948

merged 3 commits into from
Mar 27, 2023

Conversation

RakshitKumar04
Copy link
Contributor

@RakshitKumar04 RakshitKumar04 commented Mar 22, 2023 •
edited by fnhirwa
Loading

Close #12948

@RakshitKumar04
Copy link
Contributor Author

Close #12948

@RakshitKumar04
Copy link
Contributor Author

@hirwa-nshuti Created the new PR and added the floor function, please review it.

@RakshitKumar04 RakshitKumar04 mentioned this pull request Mar 22, 2023
Closed
@fnhirwa fnhirwa self-assigned this Mar 22, 2023
@fnhirwa fnhirwa changed the title floor #12085 : Added floor function to numpy frontend Added floor function to numpy frontend Mar 23, 2023
fnhirwa
fnhirwa suggested changes Mar 23, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RakshitKumar04

Thanks for contributing to ivy😊

Here are general comments for this implementation:

You'll then fix the test issues refer to the comments below
Thanks

ivy_tests/test_ivy/test_frontends/test_numpy/test_mathematical_functions/test_rounding.py Outdated Show resolved Hide resolved
@ivy-leaves ivy-leaves added the NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist label Mar 23, 2023
@RakshitKumar04
Copy link
Contributor Author

Hey, @hirwa-nshuti fixed the testing issues, please review.

fnhirwa
fnhirwa suggested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @RakshitKumar04

The tests are failing due to wrong implementation of the unit test 🙂
Would you follow the unit test of ceil function above to understand anover view as the tests will be somehow alike😊

Thanks

@RakshitKumar04
Copy link
Contributor Author

Hey @RakshitKumar04

The tests are failing due to wrong implementation of the unit test slightly_smiling_face Would you follow the unit test of ceil function above to understand anover view as the tests will be somehow alikeblush

Thanks

Hey, did the changes you suggested, Please review

fnhirwa
fnhirwa approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@fnhirwa fnhirwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Going to merge
Thanks for contributing😊

@fnhirwa fnhirwa merged commit 7f7154c into ivy-llc:master Mar 27, 2023
@RakshitKumar04
Copy link
Contributor Author

Looks good!

Going to merge Thanks for contributingblush

Thank you @hirwa-nshuti for helping me contribute to ivy.

@kiranraoboinapally kiranraoboinapally mentioned this pull request Mar 27, 2023
Closed
@fnhirwa fnhirwa mentioned this pull request Mar 29, 2023
Closed
@RakshitKumar04 RakshitKumar04 deleted the floor-patch7 branch June 20, 2023 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnhirwa fnhirwa fnhirwa approved these changes

Assignees

@fnhirwa fnhirwa

Labels
NumPy Frontend Developing the NumPy Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RakshitKumar04 @fnhirwa @ivy-leaves